Re: New package python-instagram

[Etienne Millon <me@emillon.org>]

* Jörg Frings-Fürst <debian@jff-webhosting.net> [141121 08:43]:
> Hello,
> 
> I have uploaded a new package to mentors[1..3]: python-instagram.
> 
> Please can someone reviewe the package?
> 
> Many thanks.

Hi,

The package seems fine (builds ok, lintian happy, idiomatic pybuild
etc). Although I am not a DD and cannot sponsor it, I have a few
remarks:

  - it's simpler if your packaging has the same license as he upstream
    code. Here in particular your license (GPL3) is less permissive
    than upstream's (BSD3) so it can causes problems I guess.

  - debian/python{,3}-instagram.{docs,examples} have trailing empty
    lines.

  - to get the version from debian/rules I'd suggest using something
    like "dpkg-parsechangelog|grep ^Version|cut -d' '  -f2"

  - to make the orig tarball, couldn't you use
    https://github.com/Instagram/python-instagram/archive/master.tar.gz
    and a Files-Excluded? That would require a different logic to
    generate the upstream changelog but would make the repacking
    logic way easier to read.

  - is notneededdir/unwantedfiles.* needed ?

I hope you will find a sponsor. Thanks for your hard work!

-- 
Etienne Millon