Re: RFS: kitchen, bunch, grapefruit

[Jakub Wilk <jwilk@debian.org>]

* Simon Chopin <chopin.simon@gmail.com>, 2013-04-30, 19:21:
> > We don't want embedded copies of stdlib modules in the binary package.
> I've simply removed the pycompat* modules as they're not relevant in 
> Debian anyway, and added a note in README.Debian about it.

The file name is currently “README”, you probably want to rename it.

One more thing I spotted: releaseutils.py does this:

     try:
         shutil.rmtree('locale')
     except OSError, e:
         # If the error is that locale does not exist, we're okay.  We're
         # deleting it here, afterall
         if e.errno != 2:
             raise

This is not portable. POSIX[0] says: “only […] symbolic names should be 
used in programs, since the actual value of the error number is 
unspecified.” I don't think affects Debian in any way, but please ask 
upstream to use errno.ENOENT instead of hardcoded 2. :)


[0] http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html#tag_02_03

--
Jakub Wilk