[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#701194: RFS: dparser-1.29-1 [ITP] -- a scannerless GLR parser generator

* Markus Wanner <markus@bluegap.ch>, 2013-02-24, 21:07:
W: dparser source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
Hm.. I'm wondering why I don't get this from lintian. My initial thought was that I'd have to use a newer lintian version from sid, rather than wheezy. But I can't get lintian to produce this warning even on sid.

It's currently only emitted by Lintian from experimental. (Sorry, I should have said that in my previous mail.)

e: python-dparser: string-exception usr/share/pyshared/dparser.py:215
e: python-dparser: string-exception usr/share/pyshared/dparser.py:233
e: python-dparser: string-exception usr/share/pyshared/dparser.py:236 e: python-dparser: string-exception usr/share/pyshared/dparser.py:260
While these are correctly detected - and I agree it's bad practice - do these warrant a patch?

It's not only about bad practice. String exception no longer work in Python >= 2.6:

$ python -c 'raise "foo"'
Traceback (most recent call last):
   File "<string>", line 1, in <module>
TypeError: exceptions must be old-style classes or derived from BaseException, not str

Especially considering that it leads to a difference in error handling compared to upstream.

Yeah, that's why you should bring it upstream. :)

Jakub Wilk

Reply to: