[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#701194: RFS: dparser-1.29-1 [ITP] -- a scannerless GLR parser generator



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Jakub,

thanks for your feedback.

On 02/22/2013 09:09 PM, Jakub Wilk wrote:
> Lintian emits:
> 
> W: dparser source: out-of-date-standards-version 3.9.3 (current is
> 3.9.4)

Hm.. I'm wondering why I don't get this from lintian. My initial
thought was that I'd have to use a newer lintian version from sid,
rather than wheezy. But I can't get lintian to produce this warning
even on sid.

Anyway, I corrected the package. (No changes were necessary to comply.)

> lintian4python emits:
> 
> e: python-dparser: string-exception
> usr/share/pyshared/dparser.py:215 e: python-dparser:
> string-exception usr/share/pyshared/dparser.py:233 e:
> python-dparser: string-exception usr/share/pyshared/dparser.py:236 
> e: python-dparser: string-exception
> usr/share/pyshared/dparser.py:260

While these are correctly detected - and I agree it's bad practice - do
these warrant a patch? Especially considering that it leads to a
difference in error handling compared to upstream.

> e: python-dparser: pyflakes-undefined-name 
> usr/share/pyshared/dparser.py:98: i

Interesting, this looks like a typo. I'll contact upstream. For now,
I've added a patch.

> Is "export DH_OPTIONS" in debian/rules needed for anything? I
> don't think it is.

Must be some copy'n'paste stupidity that I didn't dare to clean up.
Thanks for catching this. Removed.

I've uploaded a new version of the package to mentors.

Regards

Markus Wanner
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQQcBAEBCgAGBQJRKnLxAAoJEOhoLRs/MemzjncgAL9HTxbMKhaPYg8z1/Pngj8n
T0MbCofw2ON+8jUzhyCPYY5arUdQUFEnDU8vXNkSJo4x0UnB90I9wXeXOso+Ix1o
8c52uIOYvuK5BMKmbXkxprmZT7aGPeE7LEIL9y2pla9oMQejEsQ4o43N5Ui4aeNU
K1EJnI0t8qBQO9kTYs0jxBLGyS8d7BM7GykeEWyQ9+b/ASRl3/Ejk701rvl/l7Km
02JItN9OeoW/AG63OfABsq1xj2vpgZsEVeTwRq87U7pjFkgjHI4GGBuOFVuPiI7E
zXmDa+165wCEkJMQRi5BVqan8FErh0k8xYa/6831NC8mkne6BhWeRjsqqtxVjpO3
59SLntfQM8teHy/EEE6iFltRyrP7wnIWNory7J3gDL8icMa3/9aJ+Irb+5wmgarq
7Jd2zlH4d+WqbQNEW/5xwLDdRVGxNCes2yvj2JAA9qOnwKeyBN/G/g/tAL1JBClz
d6s4qJjU9qNi2XAD58Hv44utj6BPR45bIBiB1ZUA6fKdgAdbgCl1bw82wLLR6ATx
8U1oh2XXVcuK+t4e7fvDrjq7VcgBY54tlHkEoRz71v7eY1Ef7exgHWFFux7xmLiI
khXnZk+E5HfIWdccZAgbuzTNexuolk2mWGvK6R4NDHpOW0kV57UuPNwK5md3PvTj
xMwcMaDoquCvb5u4DryfP6vLYP3mR0GORt+YSf6pmQrsZ8FREN3zITCYjOl2qvLQ
ttCAWpQ5yJfVGEtQE/fN0kOd34BV6wHgNZXDJ0X6bTSo9/kT29gYL442AEgMrGBb
qfYlW2LDyUT1qH96ltaM9SE884x0Nxdj2qY0EaQQytA88Pc+GPkZy1kPLEGHrSWJ
AFWwZLnI95X25uRuLWSYRDFq6Y2ZCz1CR4aCs+PhjzNRc2SmzhQzBfayh5l5NH6n
+GqRmsHeDdW29J7GmSpaDYXM7oD6LfR4NqlPHT1AoG14V4CuDB5dbbN1YIsPcn1z
H7dPeM6zFIznatVC689XEM4Ixf4u16Muu8i4EYNITduAGryVM34ublnZbcl3BsYG
w2T1GD6VGvvZHdU5waj4FWyL4MwTvshaR6OufvbjZDFuRDXmRx+gqhtu+cXgSTK4
71OuNYvpdDB7Sd6qXXYvNxf8E8pycnsiEAem0CVviUBtc3KMmWE0lfldwcpFEVYn
7aFTZGI5AzHQ46ZnroLmu0tDHdXe0h/TDCFwN5vV7ALVmpQ4BOSrrLP6Bm6ohZmQ
jDzyO6LSGcV587YPC0ocKBZ3GhUqJSUi2HTWjI32sTjhuE5CmdL7eJiKBXSW9vmc
W6aD0u2HigzqCD+FgVlZpP47ie5GfHV0pqsaiMxQcvCFLlq06rg0dzKggRBnSlw=
=xTPP
-----END PGP SIGNATURE-----


Reply to: