Re: Request to Join Project Python Modules Packaging Team from Ben Carrillo (kali-guest)
* Ben Carrillo <ben@futeisha.org>, 2013-01-29, 20:02:
[0] https://mentors.debian.net/package/python-sh
I had a quick look at this one.
So... Have you talked with python-pbs maintainer about this? One could
think that you're trying to hijack the package under the guise of
upstream rename. I hope this is not the case!
Vcs-* fields are supposed to point to Debian packaging, not to upstream
repositories.
Lintian emits:
I: python-sh source: duplicate-short-description python-sh python3-sh
P: python-sh source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5
Furthermore, lintian4python emits:
e: python-sh source: invalid-python-version-declaration X-Python3-Version: <= 3.2
e: python-sh source: python3-module-but-python-depends python3-sh
e: python-sh source: python3-module-but-no-python3-depends python3-sh
e: python3-sh: missing-dependency-on-byte-compilation-helper py3compile => python3 (>= 3.1.2)
i: python-sh source: python-stdeb-boilerplate debian/rules:3 "This file was automatically generated by stdeb 0.6.0+git"
If the package isn't compatible with Python 3.3 for whatever reason,
_now_ is the time to start porting it.
The tests fail here:
| ======================================================================
| ERROR: test_non_ascii_error (__main__.Basic)
| ----------------------------------------------------------------------
| Traceback (most recent call last):
| File "test.py", line 1228, in test_non_ascii_error
| self.assertRaises(ErrorReturnCode, ls, test)
| File "/usr/lib/python2.7/unittest/case.py", line 476, in assertRaises
| callableObj(*args, **kwargs)
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 621, in __call__
| processed_args = self._compile_args(args, kwargs)
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 515, in _compile_args
| else: processed_args.append(self._format_arg(arg))
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 502, in _format_arg
| else: arg = unicode(arg).encode(DEFAULT_ENCODING)
| UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 1: ordinal not in range(128)
|
| ======================================================================
| ERROR: test_unicode_arg (__main__.Basic)
| ----------------------------------------------------------------------
| Traceback (most recent call last):
| File "test.py", line 58, in test_unicode_arg
| p = echo(test).strip()
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 621, in __call__
| processed_args = self._compile_args(args, kwargs)
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 515, in _compile_args
| else: processed_args.append(self._format_arg(arg))
| File "/build/python-sh-XinABi/python-sh-1.07/sh.py", line 502, in _format_arg
| else: arg = unicode(arg).encode(DEFAULT_ENCODING)
| UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)
|
| ----------------------------------------------------------------------
| Ran 75 tests in 20.530s
|
| FAILED (errors=2)
...but the test failures are ignored, and the binary packages are built
successfully anyway. :/
--
Jakub Wilk
Reply to: