[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: python-whisper (0.9.10)



* Jonas Genannt <jonas.genannt@capi2name.de>, 2012-06-02, 13:36:
http://anonscm.debian.org/viewvc/python-modules/packages/python-whisper/trunk/

Typo in whisper-dump.py: reda -> read.

Typo in debian/whisper-dump.1: whister -> whisper.

In whisper.py, "#!/usr/bin/env python" has been moved to last line of the file. This is very odd. Is that intentional?

"rename" is provided by perl, so you should build-depend on it. (perl happens to be transitively build-essential, since dpkg-dev depends on it. But you shouldn't rely on that.) I would also tighten the regex by adding a $ at the end of it.

--
Jakub Wilk


Reply to: