[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: style guide



On Feb 13, 2012, at 01:30 PM, Jakub Wilk wrote:

>* Barry Warsaw <barry@python.org>, 2012-02-07, 20:53:
>>http://wiki.debian.org/Python/LibraryStyleGuide
>
>* “The package […] should have a working setup.py or setup.cfg file” — err,
>* surely setup.cfg without setup.py is not enough.

It will be for Python 3.3 (i.e. pysetup3).  Clarified.

>* “there appears to be no way to prevent distribute explicitly from
>* downloading the package” — some ideas how to do it:
>
>1) Eradicate setuptools from setup.py. Not always easy or feasible, but some
>upstreams use setuptools only if it's importable, falling back to distribute
>when it's not.
>
>2) Empty install_requires and tests_reuquire (yay for consistent spelling!)
>in setup.py. If setuptools doesn't know what to download, it won't download
>anything.
>
>3) Fool setuptools into using a non-functional HTTP proxy, e.g. by setting
>this in your debian/rules:
>
>export http_proxy = http://127.0.0.1:9/
>
>(Port 9 is Discard Protocol, so it should be safe even if something is
>actually listening on the port.)

Nice.  I like this one, so I'll add it to the wiki page.  Feel free to add the
others if you think they're worth mentioning.

>* “dh_python2 will correctly fill in the installation dependencies (via
> ${python:Depends} and ${python3:Depends}” — dh_python2 doesn't touch
> python3:Depends.

Clarified.

>* “The next lines are useful if upstream has a non-standard change log that
>needs to be installed.” — this doesn't appear to have anything to do with
>Python.

Right, other than Python packages tend to have NEWS files.  It doesn't seem to
hurt to include it here.

>Also, there is some leftover flufl in this paragraph. :P

:}  Fixed!

>* “debian/*.pyremove […] Again, this does not need a Python 3 version.” - why it's not needed for Python 3?

I just meant that there doesn't need to be a specific Python 3 version of this
file (afaik).  I've rewritten that sentence for clarity.

Thanks for the great feedback!
-Barry


Reply to: