Dear Thomas, Thanks to your commit which supports Unicode table layout, html to mail converter works fine in Japanese also. Here is my comment, please find attached patch file also. 1. I think it is better to merge UnicodeFormatTable module into DPNhtml2mail.pl. Because UnicodeFormatTable.pm is almost similar to Text/FormatTable.pm. once Text::FormatTable updated, we must find difference comparing with UnicodeFormatTable. It's a pain isn't it? I make UnicodeFormatTable into sub-classed module with Text::FormatTable base class which override _uncolorized_length, _min_width, _wrap methods. 2. According to perldoc utf8, utf8::decode() is not recommend to use for any string variable, is only for string literal. Because this function does not handle arbitrary encodings. Using Encode::decode_utf8() is recommended for the general purposes. 3. I hope original Text::FormatTable supports Unicode table also in near feature. I've send a pull request to upstream via github on May 23. It is somewhat different from your code but is also working fine. But while reviewing your updates, I've got a hint from your code. I've revised the code, and I'm sending another pull request. Regards, AYANOKOUZI, Ryuunosuke -- AYANOKOUZI, Ryuunosuke <i38w7i3@yahoo.co.jp>
Attachment:
DPNhtml2mail.pl.patch
Description: Binary data
Attachment:
pgpUJSmeoME8u.pgp
Description: PGP signature