Bug#358628: init.d script checks for /usr/lib/lprng Closes: #356054
On Sat, Mar 25, 2006 at 10:41:29AM -0500, Justin Pryzby wrote:
> This initially confused me, but I think it makes sense now. I guess
> you moved required stuff from /u/s/d/ to /usr/lib/.
No, just the check. Apparently its valid to install a package and
remove documentation and the daemon should still start, so you
need to look elsewhere to stop the daemon trying to start when
the package is removed but not purged.
> Anyway I looked at the rest of your diff, and I hope you'll accept
> some further comments. Note that I'm not at all familiar with lprng
That's fine, a lot of the scripts are many years old. So probably
a lot of the answers were "that was how it was done back then"
> The first part of the initscript isn't set -e, and uses the default
> file in a strange way; that file should probably be "sourced" with
> ".", not grepped (which will fail to do the right thing, for example,
> when a comment is added). Also, IMO nonexistence of that file
> shouldn't cause the daemon to not start.
The -e should be there, as should the sourcing. I'm not sure of the
file being removed; should it be default to starting or not?
What is the administrator trying to tell lprng by deleting the file.
> At least the preinstall script, uses [ .. -a .. ] instead of the posix
> operators [ .. ] && [ .. ]. It isn't set -e, and also exits 0 on
> unknown arguments.
OK, ill check and change those.
> In the doc-base, /usr/share/doc/lprng-doc/LPRng-Reference.pdf is
> actually installed as a .pdf.gz. Same for cookbook.pdf. I wonder if
> a more general bug should be filed, to avoid having to fix individual
> packages.
They probably started off long ago not being compressed. I'm not sure
it is valid to put compressed PDFs in doc-base; if they're directly
viewable.
> The postinst also exits 0 when I think it should not. It calls the
> initscript directly, instead of using invoke-rc.d, as recommended by
> policy.
Back the the olde days we didn't have invoke-rc.d! I'll change that too.
- Craig
--
Craig Small GnuPG:1C1B D893 1418 2AF4 45EE 95CB C76C E5AC 12CA DFA5
Eye-Net Consulting http://www.enc.com.au/ MIEE Debian developer
csmall at : enc.com.au ieee.org debian.org
Reply to: