Bug#358628: init.d script checks for /usr/lib/lprng Closes: #356054
lprng (3.8.28-4) unstable; urgency=low
* init.d script checks for /usr/lib/lprng Closes: #356054
-- Craig Small <csmall@debian.org> Sun, 12 Mar 2006 11:07:00 +1100
This initially confused me, but I think it makes sense now. I guess
you moved required stuff from /u/s/d/ to /usr/lib/.
Anyway I looked at the rest of your diff, and I hope you'll accept
some further comments. Note that I'm not at all familiar with lprng
internals, so please excuse me if anything here is intentional :) I'm
Cc:ing my other bug, because there is some overlap.
The first part of the initscript isn't set -e, and uses the default
file in a strange way; that file should probably be "sourced" with
".", not grepped (which will fail to do the right thing, for example,
when a comment is added). Also, IMO nonexistence of that file
shouldn't cause the daemon to not start.
At least the preinstall script, uses [ .. -a .. ] instead of the posix
operators [ .. ] && [ .. ]. It isn't set -e, and also exits 0 on
unknown arguments.
In the doc-base, /usr/share/doc/lprng-doc/LPRng-Reference.pdf is
actually installed as a .pdf.gz. Same for cookbook.pdf. I wonder if
a more general bug should be filed, to avoid having to fix individual
packages.
The postinst also exits 0 when I think it should not. It calls the
initscript directly, instead of using invoke-rc.d, as recommended by
policy.
Justin
Reply to: