[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Execute EFI related code only for installations of grub-efi* packages.



Hi Adrian,

On 11/14/2017 01:50 PM, John Paul Adrian Glaubitz wrote:
> [...]
>> +  [ Frank Scheiner ]
>> +  * Execute EFI related code only for installations of grub-efi* packages.
> 
> Please rephrase to:
> 
>   "Query force-efi-extra-removable only when installing grub-efi*"
> 
> both in the commit message and the changelog entry.
> 
>>[...]
>> +		case $grub_package in
>> +		    grub-efi*)
> 
> Please rather match with "$ARCH:$grub_package", i.e.:
> 
> case $ARCH:$grub_package in
>                      *:grub-efi*)
> 

Unfortunately I wasn't able to start modifying the patches until this
morning. Both (and also PATCH 1/2) should be fixed with v2, which
should go out in a few minutes.

Cheers,
Frank


Reply to: