[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: pbbuttonsd doesn't work with 2.6.15 (git tree)



> > > @@ -373,7 +372,6 @@ static int uinput_burn_device(struct uin
> > >
> > >  	kfree(udev->dev->name);
> > >  	kfree(udev->dev->phys);
> > > -	kfree(udev->dev);
> > >  	kfree(udev);
> > Won't you need to explicitly free this device somewhere?
>
> Apparently not. At least, definitely not there after it's been
> unregistered (I was rewarded by the dreaded hard crash with clock reset to
> 1904 when I tried that. Suggests it's not meant to be freed).

I checked some other input drivers and they all just call
input_unregister_device() when closing the device. Seems to be standard
practice.

> I agree that it seems a bit dodgy though. Though evdev is more of a
> headache right now - that one can't even be unloaded.

Correction on this - both evdev and uinput unload fine when pbbuttonsd et
al. are stopped.

If anyone has ideas why evdev does not autoload anymore, however ...

	Michael



Reply to: