Re: pbbuttonsd doesn't work with 2.6.15 (git tree)

[Michael Schmitz <schmitz@zirkon.biophys.uni-duesseldorf.de>]

> Hi Michael,
>
> On Thu, Nov 10, 2005 at 11:42:29AM +0100, Michael Schmitz wrote:
> > -	newinput = kmalloc(sizeof(struct input_dev), GFP_KERNEL);
> > +	newinput = input_allocate_device();
> >  	if (!newinput)
> >  		goto cleanup;
> > -	memset(newinput, 0, sizeof(struct input_dev));
> >
> >  	newdev->dev = newinput;
> >
> > @@ -373,7 +372,6 @@ static int uinput_burn_device(struct uin
> >
> >  	kfree(udev->dev->name);
> >  	kfree(udev->dev->phys);
> > -	kfree(udev->dev);
> >  	kfree(udev);
> Won't you need to explicitly free this device somewhere?

Apparently not. At least, definitely not there after it's been
unregistered (I was rewarded by the dreaded hard crash with clock reset to
1904 when I tried that. Suggests it's not meant to be freed).

I agree that it seems a bit dodgy though. Though evdev is more of a
headache right now - that one can't even be unloaded.

	Michael