[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#289182: kino endianness issues on powerpc

> On Fri, Mar 25, 2005 at 01:38:27AM +0100, Daniel Kobras wrote:
> > On Tue, Mar 22, 2005 at 08:36:01PM +0000, Paul Brossier wrote:
> > > there is probably a better mean to do so though, ie checking what
> > > type of conversion is needed according to libavcodec, but it does
> > > effectively fixes the XV Display of kino.
> >
> > Actually, we should probably check the value of component_order[] in the
> > struct returned by XvListImageFormats() and shuffle components as
> > appropriate, but from the feedback so far, apparently nowadays it is
> > sufficient to keep the order of YUV components fixed, independent of
> > host arch. I've attached a patch to this effect, and would welcome
> > feedback from testers.
> it works perfectly on powerpc, a much nicer solution indeed. and
> the first patch was wrong, the image was slightly more redish.

Entirely possible; I hacked the original patch based on my limited
understanding of YUV encoding, using a perhaps flawed piece of code from
a yet earlier patch. It was enough to convice me there's some missing
endianness adjustment, and to make the display bearable.

> > > audio seems to work better now. there are a few glitches but at
> > > least it's not white noise. oh and export to mpeg2 and wav bot
> > > work.
> >
> > Great. We're getting closer, it seems. Does the video part of mpeg2
> > export also work correctly now?
> oh yes, very well. and the video filters too.

Great, thanks for testing this (and sorry I didn't report any test
results - simply didn't get around to do more video editing yet).


Reply to: