[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Linux-fbdev-devel] Re: open messes up the screen



On Wednesday 16 March 2005 12:57, Benjamin Herrenschmidt wrote:
> > Well, open is really openvt. It fiddles around with the console to
> > start up a program on a new virtual console. X doesn't always like
> > that, but it should work better than that. The vt change should
> > trigger X to properly cleanup the screen before the switch. I'd
> > say file a bug.
>
> It's not a VT change issue. It's an old bug of the fbcon code that
> causes opening a VT to reset the palette on the current fb even when not
> in front.
>

Can you try this patch?

diff -Nru a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
--- a/drivers/video/console/fbcon.c	2005-03-16 07:39:24 +08:00
+++ b/drivers/video/console/fbcon.c	2005-03-18 04:58:31 +08:00
@@ -2331,6 +2331,9 @@
 	if (fbcon_is_inactive(vc, info))
 		return -EINVAL;
 
+	if (!CON_IS_VISIBLE(vc))
+		return 0;
+
 	depth = fb_get_color_depth(&info->var);
 	if (depth > 3) {
 		for (i = j = 0; i < 16; i++) {





Reply to: