Re: problems with benh and suspend to disk

[Martin Habets <errandir_news@mph.eclipse.co.uk>]

On Wed, Apr 14, 2004 at 08:40:08AM +0200, Maciej Jan Broniarz wrote:
> On Wed, Apr 14, 2004 at 02:48:42AM +0100, Martin Habets wrote:
> > So my guess now is that you don't have drivers/char/nvram.o,
> > but have generic_nvram.o in stead... Pleas confirm this.
> >
> wolverine:/usr/src/linux/drivers/char# ls generic_nvram*  
> generic_nvram.c
> 
> i have no generic_nvram.o so the module doesnt build i guess

I think this is causing the build errors.
Do you have nvram.o?

In the config you send earlier you had:
CONFIG_GENERIC_NVRAM=y
so generic_nvram.o should have been build. Is this still the ".config"
file you have?

Check your Makefile and Kconfig in drivers/char. Not sure what to tell
you to look for... something wrong...

> > What kernel version are you on?
> >
> v2.6.5-rc3-ben0 patched for suspend-2-disk

Ok, have 2.6.5 here. Should be close enough.

> > I also have the function in arch/ppc/kernel/setup.c, along with
> > an EXPORT_SYMBOL() for it. Do you have such code?
> wolverine:/usr/src/linux/arch/ppc/kernel# grep nvram setup.c 
> #include <asm/nvram.h>
>         nvram_sync();
>         nvram_sync();
>         nvram_sync();
> /* Generic nvram hooks used by drivers/char/gen_nvram.c */
> unsigned char nvram_read_byte(int addr)
>         if (ppc_md.nvram_read_val)
>                 return ppc_md.nvram_read_val(addr);
> EXPORT_SYMBOL(nvram_read_byte);
> void nvram_write_byte(unsigned char val, int addr)
>         if (ppc_md.nvram_write_val)
>                 ppc_md.nvram_write_val(addr, val);
> EXPORT_SYMBOL(nvram_write_byte);
> void nvram_sync(void)
>         if (ppc_md.nvram_sync)
>                 ppc_md.nvram_sync();
> EXPORT_SYMBOL(nvram_sync);
> 
> so it looks fine to me.

Yes, looks good. But if CONFIG_GENERIC_NVRAM is not set (or it
thinks so), the code won't be compiled.

Martin