Re: Test patch for sleep on Aluminium PowerBooks

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Thu, 2004-10-28 at 08:33 +0200, Colin Leroy wrote:
> On 28 Oct 2004 at 07h10, Colin Leroy wrote:
> 
> Hi, 
> 
> > >                 lvds_gen_cntl |= LVDS_DISPLAY_DIS;
> > >                 OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
> > >                 lvds_gen_cntl &= ~(LVDS_ON | LVDS_BLON /* | LVDS_EN | LVDS_DIGON */);
> > >                 OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
> > 
> > I tried to, but it didn't work...
> 
> That is, I tried
>                  lvds_gen_cntl |= LVDS_DISPLAY_DIS;
>                  OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
>                  lvds_gen_cntl &= ~(LVDS_ON | LVDS_BLON /* | LVDS_EN | LVDS_DIGON */);
>                  rinfo->pending_lvds_gen_cntl = lvds_gen_cntl;
>                  mod_timer(&rinfo->lvds_timer,
>                            jiffies + msecs_to_jiffies(rinfo->panel_info.pwr_delay));
>                  //OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);

Hrm... the above doesn't seem very interesting :)

Try not doing mode_timer, add an mdelay instead (for example
mdelay(200)) before clearing ON & BLON, or first clearing ON, then
waiting, then clearing BLON, that sort of thing ...

Ben.