Re: rivafb on 12" pbook
I applied your patch to my tree. In the next week or two I will send a
patch.
On Tue, 3 Feb 2004, Guido Guenther wrote:
> On Tue, Feb 03, 2004 at 05:10:36PM +1100, Benjamin Herrenschmidt wrote:
> > Or (for rivafb) do something more like what I did in the new radeonfb,
> > that is use the data field of the PCI table to encode the architecture
> > along with some flags (like is dual head, etc...) for each chip ID, and
> > kill those redundant 3 tables we have. I also think we should get rid
> > of the ASCII names in the kernel driver. We have the PCI database for
> > this, which is an optional feature of the kernel, ultimately, naming
> > is a userland issue.
> Here's a first patch to kill the whole chip_id table (with a minor
> tradeoff that info->fix.id from now on only contains the NV_ARCH name
> not the exact card name [1]). It also cleans up and fixes the NV_ARCH
> detection as suggested by Mark and makes sure we die gracefully on
> unknown nv_archs. Applies against 2.4.2-rc2-ben1. Benjamin, could you
> please apply it?
> I'll submit this to James as soon as I can have a copy of his fbdev
> tree, is this possible without bitkeeper?
> Cheers,
> -- Guido
>
> [1] which shouldn't matter much since the 15 bytes we could store in
> there weren't sufficient anymore anyway for some cards. We still print
> the card name on bootup if we have CONFIG_PCI_NAMES defined.
>
Reply to: