I have a question, in the following part of the patch code, you set the
limits, and you take care if you have 7460 or 7467.
My question is, is correct the last asignation (below write)?
I think you have to make an "if" (like a couples of lines before) to set
the correct values for 7467 or 7460, if not, you will set the values
from 7467.
I commentd out this line (I have an 7460 chipset) and everything works
great (fan starts at 60 and stops at 57).
I am missing something?
+ for (i = 0; i < 3; i++) {
+ th->initial_limits[i] = read_reg(th, LIMIT_REG[i]);
+
+ if (therm_type == ADT7467) {
+ th->limits[i] = default_limits7467[i] - limit_decrease;
+ } else {
+ /* Set CPU limit higher on 7460 to avoid powerdowns */
+ th->limits[i] = default_limits7460[i] - limit_decrease;
+ }
+ write_reg(th, LIMIT_REG[i], th->limits[i]);
+
+ /* set our limits to normal */
+ th->limits[i] = default_limits7467[i] - limit_decrease;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ }
+
El sáb, 24-01-2004 a las 06:56, Colin Leroy escribió:
> Hi,
>
> Ok, here's the latest patch for therm_adt7467, based on the feedback provided
> by our generous testers :-)
>
> What is done now:
> . fan_speed defaults to 128 (for both chips), allowing the fan to start
> more quietly. The chip is still put back to automatic mode when we rmmod
> the module.
> . limits are set quite high on the ADT7460 chip, but the fan starts much
> below these limits (in order to avoid poweroffs).
>
> I think it's now quite OK.
> HTH,
--
My software never has bugs. | ASCII Ribbon Campaign /"\
It just develops random features. | For Standards-Complaint Email \ /
Public GnuPG key avaible at: http://www.keyserver.net X
1024D/203E154B 2003-10-03 Federico Gamio <federico@gamio.net> / \
Key fingerprint = 0B9E 3A19 C88B EBAC 5422 C05F 76B5 B922 203E 154B
sub 2048g/32D2F465 2003-10-03
Attachment:
signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente