[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: 2.6.0-ben1 : Badness in local_bh_enable at kernel/softirq.c:121



On 21/12/2003 at 10:08, Kiko Piris wrote:

> While waiting for usb-serial to be fixed, Paul Mackerras posted this
> patch against ppp_async on the lkml just some hours ago [*].
> 
> I applied it to 2.6.0-ben1 and everything seems to work fine right now.
[...]
> [*] http://marc.theaimsgroup.com/?l=linux-kernel&m=107196726402894&w=2

I spoke too fast.

I had a couple of hard freezes while connected. But as I was in X and
nothing was saved on system logs, I had absolutely no info if it was ppp
related or not. I suspected it, but really couldn't tell.

I see that this patch has been included in 2.6.0-mm1 and also in
2.6.0-ben2.

Some people reported on lkml that had oopses in ppp_async in 2.6.0-mm1
(and I guess my problem was the same, although I didn't come to "see"
the oops, I only "saw" a hard freeze).

Then Marcel Sebek noted a bug in ppp_async this morning on lkml [1] and
Andrew Morton then updated that patch [2].

I've tested it and it seems to be ok (although, pearhaps it's too soon
to tell it's full ok, I'll be testing it the following days).

As the first patch results in a ppp_async broken in 2.6.0-ben2 (with the
bug discovered by Marcel Sebek), the following patch contains the
correction in posted in [2] (and aplies against 2.6.0-ben2):

---8<---
--- drivers/net/ppp_async.c.ben2	2003-12-25 19:17:38.411240578 +0100
+++ drivers/net/ppp_async.c	2003-12-25 19:22:12.738138708 +0100
@@ -792,7 +792,7 @@
 static void
 process_input_packet(struct asyncppp *ap)
 {
-	struct sk_buff *skb;
+	struct sk_buff *skb = NULL;
 	unsigned char *p;
 	unsigned int len, fcs, proto;
 
--->8---

I'm posting this here, just in case someone just compiled 2.6.0-ben2 (or
applied the first patch) and experienced problems (oopses or hangs).

Ben, pearhaps you would like to apply it to your tree.

Thanks in advance.

[1] http://marc.theaimsgroup.com/?l=linux-kernel&m=107234722227806&w=2
[2] http://marc.theaimsgroup.com/?l=linux-kernel&m=107234795428171&w=2

-- 
Kiko

Please do not reply to the sender address of this email; due to spam and
Windows (TM) worms, everything not comming from the list is "stored" in
/dev/null. Put menorqui in the user part to send me anything.  Although,
I prefer replies sent to the list so that others can benefit from the
discussion.  Thanks.



Reply to: