Re: Sony Handycam as USB mass storage hang

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

>I had a similar problem, which I 'fixed' with this:
>
>--- /usr/local/src/linux/drivers/usb/storage/usb.c      Wed Oct
>10 13:48:40 2001
>+++ storage/usb.c       Mon Jul 30 01:41:52 2001
>@@ -438,8 +437,7 @@
>                        up(&(us->dev_semaphore));
> 
>                        /* indicate that the command is done */
>-                       if (us->srb->result != DID_ABORT << 16 
>-                           && us->srb->result != DID_ERROR << 16) {
>+                       if (us->srb->result != DID_ABORT << 16) {
>                                US_DEBUGP("scsi cmd done, result=0x%x\n", 
>                                           us->srb->result);
>                                set_current_state(TASK_INTERRUPTIBLE);
>----

Your patch sounds bad, from what I can see here, you are just
silently hiding an actual error, thus probably leading to data
corruption.

I don't know the details of what's involved here, you may want
to move the discussion to the linux-usb mailing list

Ben.