[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Minor changes to control/imstt/platinum/valkyrie/atyfb

On Tue, 27 Nov 2001, Tom Rini wrote:
> Hello all.  The following patches make slight changes to the vmode/cmode
> logic on a few fb drivers.  Now everone consistantly only tries to get
> these modes from nvram if CONFIG_NVRAM is defined (otherwise a
> compile-time error on everyone but atyfb).  On imsttfb I made the logic
> only executed on CONFIG_ALL_PPC, and removed USE_NV_MODES (which
> shouldn't be needed now).  However, I have none of this hardware, and I
> remember some of these drivers being very touchy.  So could people with
> this hardware apply the patch and let me know if it works still?

I _think_ the right solution is to hide the NVRAM vmode/cmode stuff in
macmodes.c, so all drivers will automagically use it for the default video

The same with MAC monitor sense information, just pass it to mac_find_mode().

So mac_find_mode() should do this:

  - if default mode specified, try that
  - if MAC monitor sense specified, try that
  - if NVRAM, try that
  - fall back to default mode database walking



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Reply to: