[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#119081: nano: On Oldworld PowerPC, nano freezes machine when help is being displayed

> In that message, dan says there can be problems when the va_list
> points to a char, since only promoted types are legal. I'm certainly
> wet behind the ears when it comes to this stuff, but could someone
> look at these to see if that's what's going on here?
> int statusq(int tabs, shortcut s[], int slen, char *def, char *msg, ...)
> {
>     va_list ap;
>     char foo[133];
>     int ret;
>     bottombars(s, slen);
>     va_start(ap, msg);
>     vsnprintf(foo, 132, msg, ap);
>     va_end(ap);

Unless your message format string (*msg) directs vsnprintf to print a char
c (as opposed to a char *string) or other non-promoted type, _and_ the
vsnprintf implementation is hopelessly borked, this won't hurt.

I doubt vsnprintf is broken in that respect. Plus I've not been able to
make nano crash on powerpc (Lombard, RagePro LT w/ atyfb) yet.


Reply to: