[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Save trackpad settings during sleep



On Sun, Jun 10, 2001 at 09:31:42PM +0200, Michael Schmitz wrote:
> > > But we run pmud before the device wakeup has done. This is extremely bad,
> > > opening /dev/adb should return -EAGAIN while the bus state isn't sane, as 
> > > after sleep (there isn't anything user space related to care about before 
> > > ADB is initialized on boot).
> > 
> > Er, quickly reading pmud.c, it _looks_ like we open the device (/dev/adb) once
> > and after that always assume it's open/sane.  Same w/ /dev/pmu.  It also
> 
> Bad assumption. But we can extend the error detection to reads and writes
> easily, right? I've stopped hacking on the ADB code long time ago so my
> memory is fuzzy there.

Er, assuming ADB_{READ,WRITE}REG end up talking to /dev/adb and aren't just
trying to magically work, yes.   Then pmud should just work on the old
setup and new as well..

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/



Reply to: