[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#904248: Beginnings of a patch to add netbase to build-essential



Hi,

On Mon, Aug 06, 2018 at 07:06:45PM +0800, Sean Whitton wrote:
> Here is the complete patch, for which I am seeking seconds:
> 
> diff --git a/policy/ch-source.rst b/policy/ch-source.rst
> index 9e7d79c..011893c 100644
> --- a/policy/ch-source.rst
> +++ b/policy/ch-source.rst
> @@ -40,9 +40,25 @@ example, if building a package requires a certain compiler, then the
>  compiler should be specified as a build-time dependency.
> 
>  It is not necessary to explicitly specify build-time relationships on a
> -minimal set of packages that are always needed to compile, link and put
> -in a Debian package a standard "Hello World!" program written in C or
> -C++. The required packages are called *build-essential*, and an
> +minimal set of packages that are always needed
> +
> +- to compile, link and put in a Debian package a standard "Hello
> +  World!"  program written in C or C++;
> +
> +- for the package build to resolve the system hostname to a
> +  fully-qualified domain name using the C standard library; and
> +
> +- for the package build to look up longstanding and conventionally
> +  available service and protocol names and numbers, either by directly
> +  reading /etc/services and /etc/protocols, or by using the
> +  corresponding functions from the C standard library. [#]_
> +
> +  (If the package needs to look up a more recent service or protocol,
> +  and certainly if the service or protocol was not listed in these
> +  files in the package's targeted Debian releases, an appropriate
> +  versioned build-dependency is needed.)
> +
> +The required packages are called *build-essential*, and an
>  informational list can be found in
>  ``/usr/share/doc/build-essential/list`` (which is contained in the
>  ``build-essential`` package).  [#]_
> @@ -757,6 +773,10 @@ according to this convention, the C source code of an executable
>  ``debian/missing-sources/checksum/util.c``.
> 
>  .. [#]
> +   The functionality described in these last two list items is
> +   provided by the "netbase" package at the time of writing.
> +
> +.. [#]
>     Rationale:
> 
>     -  This allows maintaining the list separately from the policy
> 

I hereby disagree with this approach.
I think that if we were going this way, build-essential should just
start depending on netbase instead.

Changing the Policy wording to say that build-essential should also
provide networking base stuff it's probably fine though.

I think we also need a wider request for /etc/services and
/etc/protocols.  Till now I only heard Ian asking for it, so I believe
there needs to be a wider request.


Talking about the proposed wording: the text within parenthesis mentions
"versioned build-dependency", but the package it's talking about
(netbase, I suspect) it's only mentioned in the footnote, which is an
issue in my book.


On the note of /etc/hosts, I'm fixing the original bug rised by Simon
McVittie (that was triggered by tests.reproducible-builds.org not
resolving localhost) within pbuilder (#905307) btw.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: