Bug#460486: marked as done (debian-policy: Section 10.1 has a mistake in example)
Your message dated Sun, 13 Jan 2008 01:11:32 -0500
with message-id <730e8cfc0801122211s5a8c5983w5a85a387a5eaee34@mail.gmail.com>
and subject line Bug#460486: debian-policy: Section 10.1 as a mistake in example makefile snippet.
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: debian-policy
Version: 3.7.3
Tags: patch
Debian Policy Section 10.1 contains the following makefile snippet in
regards to using the 'nostrip' option.
ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL_PROGRAM += -s
endif
It should be:
ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL_PROGRAM += -s
endif
--
Regards,
Andres Mejia
--- End Message ---
--- Begin Message ---
On Jan 13, 2008 12:54 AM, Russ Allbery <rra@debian.org> wrote:
> "Andres Mejia" <mcitadel@gmail.com> writes:
>
> > Package: debian-policy
> > Version: 3.7.3
> > Tags: patch
> >
> > Debian Policy Section 10.1 contains the following makefile snippet in
> > regards to using the 'nostrip' option.
> >
> > ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
> > INSTALL_PROGRAM += -s
> > endif
>
> $(findstring nostrip,$(DEB_BUILD_OPTIONS)) will return the empty string if
> nostrip is *not* present in DEB_BUILD_OPTIONS.
>
> ifeq compares the results to the empty string.
>
> Therefore, the effect of this makefile fragment is to add -s to
> INSTALL_PROGRAM if nostrip is *not* present in DEB_BUILD_OPTIONS.
>
> I believe that's correct. It is extremely counterintuitive and I had to
> read it multiple times myself to be sure I understood it.
>
> --
> Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
>
Alright, I understand it now. It had me confused as well.
--
Regards,
Andres Mejia
--- End Message ---
Reply to: