[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#76868:



On Sun, Nov 12, 2000 at 12:32:46PM -0800, Chris Waters wrote:
> On Sun, Nov 12, 2000 at 02:36:24PM -0200, Henrique M Holschuh wrote:
> > +     `restart-if-running'
> > +          stop the service, and if the service was running before being
> > +          stopped by restart-if-running, restart it,
> It seems like there are really two proposals here, bundled as one.

I agree here. I'd happily second a proposal *just* including invoke-rc.d
(without including a restart-if-running, and therefore not falling
back to it), and I suspect invoke-rc.d on its own is probably close
to uncontroversial.

I still don't like restart-if-running though. I don't think "if"s should be
in the arguments, and I'd be much more inclined towards something like:

	if [ `/etc/init.d/foo status` = "running" ]; then
		/etc/init.d/foo restart
	fi

I'm also (duh) against falling back to a new, optional argument without
any indication that's appropriate when called. I think that's a really bad
design. But I'm not really sure what more I can say to convince you this
is a bad idea. :-/

Any chance you could be convinced to split this into two separate
proposals?

Cheers,
aj

-- 
Anthony Towns <aj@humbug.org.au> <http://azure.humbug.org.au/~aj/>
I don't speak for anyone save myself. GPG signed mail preferred.

  ``We reject: kings, presidents, and voting.
                 We believe in: rough consensus and working code.''
                                      -- Dave Clark

Attachment: pgp1w40NKx2I4.pgp
Description: PGP signature


Reply to: