[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New packages for review

On Wed, 05 Nov 2025 23:52:44 +1300, Andrew Ruthven wrote:


Thank you. I've fixed most of the things noted. There are some things like
to hear further thoughts on, please see below (where I've deleted bullets,
I've fixed them and nothing further to note).



> libobject-import-perl
> https://salsa.debian.org/perl-team/modules/packages/libobject-import-
> perl

* d/copyright: that's unusual:
   "??, Max Maischein <corion@cpan.org>"
   :)
   and in general I only see Zsban Ambrus as a copyright holder


Place holder where I was intending to dig further. Max doesn't appear to
have exerted any copyright, so removed.
Fixed. Pushed to Salsa.


Sounds good.


> libwww-mechanize-chrome-perl
> https://salsa.debian.org/perl-team/modules/packages/libwww-mechanize-
> chrome-perl
> This one isn't ready for upload yet, there are two failing tests. I've
> created tickets upstream for them. However, the package can still be
> reviewed.


Fixed. Pushed to Salsa.
However I'm still working with upstream to get all the tests passing. I am
reassured that the Fedora packager is having the same tests fail.


Makes sense.


> libselenium-remote-driver-perl
> https://salsa.debian.org/perl-team/modules/packages/libselenium-remote-
> driver-perl
* lib/Selenium/Firefox/webdriver.xpi sounds interesting :)
   And looking into it is even more interesting, e.g. there's a
   Windows .dll in it …

Digging a bit into this, it is only used for Firefox < 48. So pretty much
ancient history now. I'm thinking that I should repack the orig source to
remove the xpi file. See
https://salsa.debian.org/perl-team/modules/packages/libselenium-remote-driver-perl/-/blob/debian/latest/lib/Selenium/Firefox/Profile.pm?ref_type=heads#L343
.
Oh, nice if this file is not needed, and yes, repacking seems to be the way to go. 


Cheers,
gregor

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-

Attachment: signature.asc
Description: Digital Signature

Reply to: