Re: New packages for review
Hey Gregor,
Thank you. I've fixed most of the things noted. There are some things like
to hear further thoughts on, please see below (where I've deleted bullets,
I've fixed them and nothing further to note).
On Sun, 2025-10-12 at 15:41 +0200, gregor herrmann wrote:
> On Tue, 07 Oct 2025 00:21:51 +1300, Andrew Ruthven wrote:
>
> Some rather quick review:
>
> > libwebservice-dropbox-perl
> https://salsa.debian.org/perl-team/modules/packages/libwebservice-dropbox-perl
Fixed. Pushed to Salsa.
> > libalgorithm-loops-perl
> https://salsa.debian.org/perl-team/modules/packages/libalgorithm-loops-perl
Fixed. Pushed to Salsa.
>
> > libfuture-http-perl
> https://salsa.debian.org/perl-team/modules/packages/libfuture-http-perl
Fixed. Pushed to Salsa.
>
>
> > libmoox-role-eventemitter-perl
> > https://salsa.debian.org/perl-team/modules/packages/libmoox-role-
> > eventemitter-perl
Fixed. Pushed to Salsa.
> > libobject-import-perl
> > https://salsa.debian.org/perl-team/modules/packages/libobject-import-
> > perl
>
> * d/copyright: that's unusual:
> "??, Max Maischein <corion@cpan.org>"
> :)
> and in general I only see Zsban Ambrus as a copyright holder
Place holder where I was intending to dig further. Max doesn't appear to
have exerted any copyright, so removed.
Fixed. Pushed to Salsa.
> > libnet-async-websocket-perl
> > https://salsa.debian.org/perl-team/modules/packages/libnet-async-
> > websocket-perl
Fixed. Pushed to Salsa.
> > libwww-mechanize-chrome-perl
> > https://salsa.debian.org/perl-team/modules/packages/libwww-mechanize-
> > chrome-perl
> > This one isn't ready for upload yet, there are two failing tests. I've
> > created tickets upstream for them. However, the package can still be
> > reviewed.
Fixed. Pushed to Salsa.
However I'm still working with upstream to get all the tests passing. I am
reassured that the Fedora packager is having the same tests fail.
> > libselenium-remote-driver-perl
> > https://salsa.debian.org/perl-team/modules/packages/libselenium-remote-
> > driver-perl
>
> * 1.50 is available upstreams :)
Sneaky upstreams fixing things. But includes the patches I forwarded.
> * lib/Selenium/Firefox/webdriver.xpi sounds interesting :)
> And looking into it is even more interesting, e.g. there's a
> Windows .dll in it …
Digging a bit into this, it is only used for Firefox < 48. So pretty much
ancient history now. I'm thinking that I should repack the orig source to
remove the xpi file. See
https://salsa.debian.org/perl-team/modules/packages/libselenium-remote-driver-perl/-/blob/debian/latest/lib/Selenium/Firefox/Profile.pm?ref_type=heads#L343
.
Other items fixed. Pushed to Salsa.
Cheers,
Andrew
--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |
Reply to: