Re: Thoughts on Markdown::Render
On Tue, 2024-07-16 at 20:31 +0200, gregor herrmann wrote:
> On Tue, 16 Jul 2024 21:16:53 +1200, Andrew Ruthven wrote:
> > The new package is ready for review here:
> > https://salsa.debian.org/perl-team/modules/packages/libmarkdown-render-
> > perl
>
> * Out of curiosity: Why the opts="pgpmode=none" in d/watch?
I wanted to stop uscan from complaining about no GPG sigs, and as a first
attempt to make lintian happy. But I see that even in verbose mode uscan
isn't trying to fetch the GPG sig file. I have removed it.
> * Remark/question: we have no copyright holder anywhere. As a
> workaround, we typically copy the "Berne Convention" comment from
> https://perl-team.pages.debian.net/copyright.html#Berne_Convention
> into debian/copyright (done). But the question remains who the
> author(s) actually is/are? You picked 'Rob Lauer
> <rlauer6@comcast.net>' which looks right from looking at
> lib/Markdown/Render.pm and ChangeLog and the git log but
> Makefile.PL has
> AUTHOR => 'BIGFOOT <bigfoot@cpan.org>'
> Might be an oversight / copypaste error but things like this raise
> ftp-masters' eyebrows :)
> So maybe either ask upstream for clarification (and put this in
> d/copyright), or extend the Comment I've added with a sentence
> explaining the situation.
Yeah, good question. I couldn't find a copyright statement in the code
either. BIGFOOT is Rob Lauer's CPAN username -
https://metacpan.org/author/BIGFOOT . I figured it would be better to use
his personal address as included in the docs than his CPAN email address.
Given this relationship, I don't think there is confusion on who the
copyright holder is - just inconsistency in the package.
I have added this to the comment that you've added (thank you for that).
> * Some cosmetic fixes committed and pushed.
Ta.
> Oh, dear, this needs libio-stringy-perl (>= 2.113) which I've already
> deleted :)
Haha, yes, this is why I was looking at libio-string-perl.
> Alright, after that: Everything else looks fine to me.
Excellent.
--
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |
Reply to: