[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Thoughts on Markdown::Render



Hey,

As part of updating request-tracker5 to v5.0.7, a new build dependency is
Markdown::Render[0], I'm preparing this currently, but, I wanted to get some
thoughts. By default it will use a Github API to render Markdown to HTML. I
figure that isn't ideal from a privacy of our users point of view.
Fortunately the module also supports using Text::Markdown::Discount to do
the rendering locally.

It is a trivial patch to change the default to be Text::Markdown::Discount,
is this the correct thing to do?

I don't think upstream will accept the patch, as they've deliberately set
the default to be Github.

There is nothing to worry about tests reaching out to Github during builds
as there is no test suite (sigh).

Cheers,
Andrew

[0] https://metacpan.org/pod/Markdown::Render
-- 
Andrew Ruthven, Wellington, New Zealand
andrew@etc.gen.nz         |
Catalyst Cloud:           | This space intentionally left blank
 https://catalystcloud.nz |


Reply to: