Re: RFS: libinfluxdb-http-perl 0.04 (new package)

[Gabriel Filion <gabster@lelutin.ca>]

Hi,

I'm finally reaching out to this small project

Thanks again Gregor for the insightful feedback you sent me back in june!

I've sent commits to implement the changes that were suggested:

On 2022-06-20 17:04, gregor herrmann wrote:
> On Sun, 19 Jun 2022 16:13:00 -0400, Gabriel Filion wrote:
> > https://salsa.debian.org/perl-team/modules/packages/libinfluxdb-http-perl

> Some notes:
> - I wouldn't install the README.pod as it is the same as the POD (and
>    the manpage)
>    % diff -u <(pod2text README.pod) <(pod2text lib/InfluxDB/HTTP.pm)
>    `perldoc InfluxDB::HTTP' and `man InfluxDB::HTTP' should be enough
>    :)

right, duplication is not great. done!

> - W: libinfluxdb-http-perl source: no-nmu-in-changelog
>    W: libinfluxdb-http-perl source: source-nmu-has-incorrect-version-number 0.04-1
>    That's because you use a different mail adress in d/control and
>    d/changelog.

oh, fixed. I'm currently changing jobs anyway so I should use another 
email address if I want to continue maintaining the package with the team.

> - I: libinfluxdb-http-perl: synopsis-is-a-sentence "Perl way to interact with InfluxDB."
>    --> remove full stop at the end

done

> - I: libinfluxdb-http-perl: typo-in-manual-page usr/share/man/man3/InfluxDB::HTTP.3pm.gz line 151 reponse response
>    Upstream might be happy about a patch :)

I've sent a PR upstream to fix this typo.

> So you can also remove the libtest-simple-perl build dependency
> (coming from META.*; not that this changes anything, as it's provided
> by src:perl).

ok, the dependency is removed.

> As for autopkgtests, I'd still add the
> "Testsuite: autopkgtest-pkg-perl"
> field, as there are more tests than running the smoke tests.

ah yes ok, so this will run some basic perl smoke tests I guess?

I've added this field to the control file.

> # Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 13.
>
> So libjson-maybexs-perl is missing in Depends (and the upstream
> metadata).
>
> Next one:
> # Can't locate LWP/UserAgent.pm in @INC (you may need to install the LWP::UserAgent module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 14.
>
> So let's add libwww-perl to Depends.

added both

> And let's look at the actual code:
>
> use JSON::MaybeXS;
> use LWP::UserAgent;
> use Object::Result;
> use URI;
>
> We have liburi-perl but *drumroll* we're back to packaging Object::Result
> which you wanted to avoid :)

oh blah you're totally right. the Object::Result is used at runtime in 
the library, so there's no escaping packaging it!

I took a quick look at the code from Object::Result and all dependencies 
are already packaged in debian.

I'll try and create another new package for that second lib soon.