On Tue, 16 Aug 2022 02:40:37 -0400, Gabriel Filion wrote: > I'm finally reaching out to this small project Yay :) > Thanks again Gregor for the insightful feedback you sent me back in june! You're welcome. > > - I: libinfluxdb-http-perl: typo-in-manual-page usr/share/man/man3/InfluxDB::HTTP.3pm.gz line 151 reponse response > > Upstream might be happy about a patch :) > I've sent a PR upstream to fix this typo. Great. > > So you can also remove the libtest-simple-perl build dependency > > (coming from META.*; not that this changes anything, as it's provided > > by src:perl). > ok, the dependency is removed. (Looking at the commit message: It's more that it's not used than that Test::More is also in src:perl; the latter just means that the separate libtest-simple-perl wouldn't have been installed as it's also Provided.) > > As for autopkgtests, I'd still add the > > "Testsuite: autopkgtest-pkg-perl" > > field, as there are more tests than running the smoke tests. > ah yes ok, so this will run some basic perl smoke tests I guess? See https://perl-team.pages.debian.net/autopkgtest.html for a description of the tests. (In this unusual case smoke.t is not run, as there is no t/*.t and no test.pl, but both use.t and syntax.t caught the missing dependencies.) > > # Can't locate JSON/MaybeXS.pm in @INC (you may need to install the JSON::MaybeXS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 13. > > # Can't locate LWP/UserAgent.pm in @INC (you may need to install the LWP::UserAgent module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 /usr/share/perl/5.34 /usr/local/lib/site_perl) at /usr/share/perl5/InfluxDB/HTTP.pm line 14. > added both Cool. > > And let's look at the actual code: > > > > use JSON::MaybeXS; > > use LWP::UserAgent; > > use Object::Result; > > use URI; > > > > We have liburi-perl but *drumroll* we're back to packaging Object::Result > > which you wanted to avoid :) liburi-perl is still missing in Depends. Well, and the not-yet-packaged libobject-result-perl as well. > oh blah you're totally right. the Object::Result is used at runtime in the > library, so there's no escaping packaging it! Ack. > I took a quick look at the code from Object::Result and all dependencies are > already packaged in debian. > I'll try and create another new package for that second lib soon. Just shout when it's in git :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-
Attachment:
signature.asc
Description: Digital Signature