[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#950972: press: Broken/mangled space characters in 10.3 and 9.12 point release announcements



Control: tags -1 patch

Hi!

On Sat, 2020-02-08 at 23:32:56 +0100, Salvatore Bonaccorso wrote:
> Just checked quickly, in the script there is a U+00A0 (0xc2 0xa0) which seem to
> cause the issue. If I replace the space with "normal" space U+0020, then the
> issue disapear. The issue at least is triggerable as well with older issues not
> only the recent 2020 ones.

As has been mentioned in the bug report, there are other UTF-8
literals in the script, so replacing that one character does not fix
the issue.

> I do not know if this is the right solution, but attached patch with the above.

See above.

I think the attached patch is the correct fix. I think I can push to
the repo, so if no one has any concerns I might do that during the
weekend.

Thanks,
Guillem
From 1dcd625cd3282e66782cbe13e3fada43dd59e139 Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Sat, 9 Oct 2021 16:38:39 +0200
Subject: [PATCH] DPNhtml2mail: Set stdout encoding to UTF-8

We are printing UTF-8 characters, and should make the output match,
otherwise we get local encodings.
---
 dpn/scripts/DPNhtml2mail.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dpn/scripts/DPNhtml2mail.pl b/dpn/scripts/DPNhtml2mail.pl
index 8188dc5b..d4682d73 100755
--- a/dpn/scripts/DPNhtml2mail.pl
+++ b/dpn/scripts/DPNhtml2mail.pl
@@ -148,6 +148,8 @@ my $default_dpn_url  = 'https://www.debian.org/News/weekly/';
 my $default_news_mail = 'press@debian.org';
 my $default_news_url  = 'https://www.debian.org/News/';
 
+binmode STDOUT, ':utf8';
+
 # Option parsing
 GetOptions(\%opts, 'u|url=s', 'i|issue=s', 'l|lang=s', 'd|debug', 't|type=s', 'm|mail=s', 'wrap-list', 'do-not-wrap=s');
 
-- 
2.33.0


Reply to: