[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFP for bioperl's Bio-EUtilities



On Mon, 23 Jan 2017 22:45:24 +0100, Andreas Tille wrote:

> > The first is from a missing dependency (Bio::ASN1::EntrezGene),
> > which is really optional (the comp test should skip that
> > directory). The other is from XML::Simple, which is unusual; I’m
> > wondering whether the underlying XML parser is checking the XML
> > schema for the test reports. Any idea what the specific XML::SAX
> > backend parser module used was?
> 
> Sorry, I've sended a wrong version of the log with missing
> Build-Depends.  Please check again.

The tests fail for me as well, in a chroot with networking firewalled
off.

The errors are slightly different, probably because I have http_proxy
set:

http error : Operation in progress
XML::Simple called at /build/libbio-eutilities-perl-1.75/blib/lib/Bio/Tools/EUtilities.pm line 140.
# Looks like your test exited with 255 before it could output anything.
t/egquery.t ................. 
1..18
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 18/18 subtests 

etc. for all t/e*.t tests

/*
With http_proxy unset I get:

http error : Unknown IO error
http error : connection refused
XML::Simple called at /build/libbio-eutilities-perl-1.75/blib/lib/Bio/Tools/EUtilities.pm line 140.
# Looks like your test exited with 255 before it could output anything.
t/egquery.t ................. 
1..18
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 18/18 subtests 

*/

Anyway, it's quite clear that the tests try to access the internet
which is forbidden by Debian policy (regardless of the fact if the
fail gracefully or not), so they have to be skipped.

Andreas, you already know the trick with debian/tests/pkg-perl/smoke-skip
and using the file in debian/rules as well to disable tests during
build + autopkgtest. If you don't run okg-perl-autopkgtests, you can
use:

#v+
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,13 @@
 #!/usr/bin/make -f

+TEST_FILES = $(filter-out $(wildcard t/e*.t),$(wildcard t/*.t))
+
 %:
        dh $@

 override_dh_installchangelogs:
        dh_installchangelogs Changes
+
+override_dh_auto_test:
+       # disable tests which need a network connection
+       dh_auto_test -- TEST_FILES="$(TEST_FILES)"
#v-


Of course an upstream fix, e.g. skipping tests if
$ENV{NETWORK_TESTING} is not set etc., would be nicer.
(Hm, is this the package that was discussed on #debian-perl on IRC
earlier yesterday? :))


BTW: I think override_dh_installchangelogs in d/rules is not needed,
dh_installchangelogs should find Changes by itself.
 

Cheers,
gregor


-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Track 6

Attachment: signature.asc
Description: Digital Signature


Reply to: