[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of mysql-sandbox

It took a while, but I have uploaded an updated version (with all the issues you raised fixed) of the package to mentors.d.n [1]. I have issued a new RFS bug [2], hopefully it will attract a sponsor. Perhaps someone from the debian perl group could review it and sponsor it?

[1] https://mentors.debian.net/package/mysql-sandbox
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790761

2014-05-28 13:43 GMT+02:00 Daniel Lintott <daniel@serverb.co.uk>:
Hi Mateusz,

I came across your package on mentors.d.o and was intrigued so decided
to give the package a review.

NB: I'm not a DD, so can't actually sponsor you myself... But hopefully
this will help point you in the right direction.

Currently there is a small FTBFS (that occurs only under sbuild, which
the buildd's use). The package fails to build at the test section as it
tries to create a directory in the users home directory (sbuild sets
$HOME = /sbuild-nonexistent). A small modification(taken from the
glib2.0 package) to your debian/rules fixes this:

# Do not clutter $HOME with ~/sandboxes and avoid failure on the buildds
# where creating /home/buildd/sandboxes fails
export HOME=$(CURDIR)/debian

With the package built we can cover the Lintian warnings:

> W: mysql-sandbox: debian-changelog-line-too-long line 4

As mysql-sandbox has never been uploaded to Debian you can simply remove
this line, leaving just the single 'Initial Release' line.

> W: mysql-sandbox: script-with-language-extension usr/bin/deploy_to_remote_sandboxes.sh

All files installed into a directory in PATH shouldn't have a language
extension. The easiest fix for this would be to rename the file in
debian/rules, see [0] for an example solution.

> W: mysql-sandbox: binary-without-manpage usr/bin/deploy_to_remote_sandboxes.sh

This doesn't appear to have a manpage or any mention in any files...
Maybe ask upstream to see if they can supply a manpage for this (this
wouldn't block an upload though)

> W: mysql-sandbox: binary-without-manpage usr/bin/msb

msb is found the MySQL::Sandbox.3pm manpage, adding another symlink for
this is fine.

> debian/copyright:
    + Rather than duplicating the license twice, you can use a single
licence block, see [1].
    + Consider using metacpan.org as the source URL (see below)

> debian/mysql-sandbox.docs
    + No need to install the README, it's just a copy of the manpages

> debian/copyright, debian/watch
    + Consider using metacpan.org [2] for the watch URL as this will
allow the upstream to be tracked should it be taken over by a different
author on CPAN.

It also be worth contacting the guys at the Debian Perl Group [3]
(cc'd), you may find someone there who is willing to sponsor your package.

[0] http://sources.debian.net/src/libvm-ec2-perl/1.25-1/debian/rules#L11
[1] http://sources.debian.net/src/gns3/0.8.6-3/debian/copyright
[2] https://metacpan.org/release/MySQL-Sandbox
[3] https://wiki.debian.org/Teams/DebianPerlGroup

Daniel Lintott
GPG Key: 4096R/5D73EC6E

Reply to: