On Wed, 10 Sep 2014 21:33:21 +0200, Martin Pitt wrote: > Niko Tyni [2014-09-10 19:58 +0300]: > > Thanks for the "needs-recommends" hint, I had missed that. I expect > > it would fix most of the problems, and we could still auto-skip packages > > with Suggestions if there too many of them to handle individually. Yeah, probably. > > It would need a new section in the test control file, something like > > > > Test-Command: /usr/share/pkg-perl-autopkgtest/runner with-recommends > > Depends: @, pkg-perl-autopkgtest > > Restrictions: needs-recommends > > > > and updating pkg-perl-autopkgtest accordingly. > > What would need changing in pkg-perl-autopkgtest? Moving syntax.t from the runtime-deps.d/ dir to a new with-recommends.d/ directory where "runner with-recommends" than finds it. The way this runner works now is that different sets of tests with different Depends/Restrictions are in different sub-dirs. (Plus adjusting the Makefile.) > Or do you mean > https://anonscm.debian.org/cgit/pkg-perl/packages/pkg-perl-tools.git/commit/?id=444745528c ? That too. > (FWIW, that smells a bit too much like black magic to me, but we are > still in the early tuning steps after all) :) > > I'm asking because while we designed our generic test control files as > > extensible as possible without modification, we didn't envision needing > > this "needs-recommends" thing. There are probably only a few dozen copies > > of the control file uploaded at this point, so updating them is still > > easy. But the next necessary modification might need two hundred or two > > thousand uploads to get all the packages converted. > Right, and it might just be easier and preferable to drop the explicit > control files? Anyway, if the packages that already have it succeed > their tests, there is no reason to add the restriction. It's more about adding a new stanza to run the fourth type of tests. Or IOW: If we move syntax.t from runtime-deps.d/ to with-recommends.d/ then it won't get run for those packages until we update d/t/control to call "runner with-recommends". -- As Niko said no big deal at the moment: % md5sum */debian/tests/control d702aecccd0f8675efe7d471f2290750 libapp-fatpacker-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libcatalyst-model-dbic-schema-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libcgi-fast-perl/debian/tests/control 1f1d82ca6a8c823b324a436c0071ac90 libcli-framework-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libcpan-meta-requirements-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libcpan-perl-releases-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdatetime-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdatetime-timezone-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdbix-class-helpers-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdbix-class-schema-loader-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdist-zilla-plugin-run-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libdist-zilla-plugin-test-reportprereqs-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libfindbin-libs-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libgnupg-interface-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libhttp-tiny-perl/debian/tests/control bfb30b6c0d07ca3257f86552bb2fdd5b liblingua-en-numbers-ordinate-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libmodule-build-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libmodule-build-tiny-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libmoose-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libnamespace-autoclean-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libnet-github-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libnet-inet6glue-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libnumber-phone-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 librpc-xml-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libterm-sk-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-cleannamespaces-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-deep-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-file-sharedir-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-harness-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-kwalitee-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-longstring-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-mock-redis-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-requiresinternet-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-routine-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-simple-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-version-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtest-without-module-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libtext-bibtex-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libutf8-all-perl/debian/tests/control d702aecccd0f8675efe7d471f2290750 libxml-parser-perl/debian/tests/control [Interesting *cough*] [#759753 (include directive in test control] > But I understand that with the current fully dynamic method this isn't > very urgent, or am I missing something? Depends on if we stop to add d/t/control files to packages that we have to change later :) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Dawn Landes: Private Little Hell
Attachment:
signature.asc
Description: Digital Signature