Re: ci.debian.org and pkg-perl packages
On Tue, Sep 09, 2014 at 05:13:34PM +0200, Martin Pitt wrote:
> I ran over 1.400 package tests on my laptop today (titanpad is up to
> date), and so far the results look rather promising. There are 168
> failures (https://people.debian.org/~mpitt/tmp/perl-failures/) and 94
> packages which don't have tests (at the end of the pad), i. e. which
> should be removed from the whitelist. That means that the other ~ 1150
> packages succeeded.
That's a bit worse than I expected but not overly so, and we already
have a couple of generic fixes. So this still looks useful :)
The heavy-deps tests are currently no-ops and seem like a waste of
resources in this context. Patch (untested but mostly trivial) attached.
Would it be possible to put a tarball of the failure logs available too
to avoid recursive web crawling? I'd like to run some massaging to get
an overview of the failure modes and their frequencies.
> I suggest we start using the whitelist with the "passed" ones to avoid
> showing hundreds of new failures.
Sure, that seems sensible.
Many thanks for your work on this!
--
Niko Tyni ntyni@debian.org
>From 10d1c2b9f76681579b5758ba757ae1762a881758 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Tue, 9 Sep 2014 21:16:14 +0300
Subject: [PATCH] Don't synthesize the no-op 'heavy' perl tests for now
These no-op tests are bundled in the pkg-perl default test control
file so that future expansion will not require source uploads for all
packages. This is not a concern with the synthesized test control file,
which is easy to update centrally when necessary.
So let's save the CPU cycles for something more useful until
the future expansion actually happens.
---
doc/README.package-tests.rst | 3 ---
lib/testdesc.py | 7 -------
tests/testdesc | 6 +-----
3 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/doc/README.package-tests.rst b/doc/README.package-tests.rst
index b3e9db4..afc3cb8 100644
--- a/doc/README.package-tests.rst
+++ b/doc/README.package-tests.rst
@@ -267,9 +267,6 @@ Implied control file: ::
Test-Command: /usr/share/pkg-perl-autopkgtest/runner runtime-deps
Depends: @, pkg-perl-autopkgtest
- Test-Command: /usr/share/pkg-perl-autopkgtest/runner heavy-deps
- Depends: @, pkg-perl-autopkgtest, pkg-perl-autopkgtest-heavy
-
Reboot during a test
--------------------
diff --git a/lib/testdesc.py b/lib/testdesc.py
index 62ece40..4d85fd4 100644
--- a/lib/testdesc.py
+++ b/lib/testdesc.py
@@ -332,13 +332,6 @@ def _auto_debian_control_perl(srcdir, tests):
tests.append(Test('auto-runtime-deps', None, command, [], [],
depends, []))
- command = '/usr/share/pkg-perl-autopkgtest/runner heavy-deps'
- depends = _parse_debian_depends(command,
- '@, pkg-perl-autopkgtest-heavy',
- srcdir)
- tests.append(Test('auto-heavy-deps', None, command, [], [],
- depends, []))
-
def _auto_debian_control(srcdir):
'''Infer tests if there is no Debian test control file'''
diff --git a/tests/testdesc b/tests/testdesc
index 1ff8a1c..fdead50 100755
--- a/tests/testdesc
+++ b/tests/testdesc
@@ -437,7 +437,7 @@ class Debian(unittest.TestCase):
(ts, skipped) = self.call_parse(None, 'Source: libfoo-perl\n\n'
'Package: libfoo-perl\nArchitecture: all')
- self.assertEqual(len(ts), 3)
+ self.assertEqual(len(ts), 2)
self.assertRegex(ts[0].command, 'pkg-perl-autopkgtest.*build-deps')
self.assertIn('pkg-perl-autopkgtest', ts[0].depends)
@@ -447,10 +447,6 @@ class Debian(unittest.TestCase):
self.assertIn('pkg-perl-autopkgtest', ts[1].depends)
self.assertIn('libfoo-perl', ts[1].depends)
- self.assertRegex(ts[2].command, 'pkg-perl-autopkgtest.*heavy-deps')
- self.assertIn('pkg-perl-autopkgtest-heavy', ts[2].depends)
- self.assertIn('libfoo-perl', ts[2].depends)
-
class Click(unittest.TestCase):
@classmethod
--
2.1.0
Reply to: