Re: libdate-manip-perl build depends
Hi Gregor,
On Wednesday 12 June 2013, gregor herrmann wrote:
> On Wed, 12 Jun 2013 16:06:09 +0200, Carsten Wolff wrote:
> > libdate-manip-perl build-depends on libmodule-build-perl (>= 0.390000) |
> > perl (>= 5.15.2). Why is this necessary?
>
> META.yml contains:
>
> configure_requires:
> Module::Build: 0.39
>
> It's well possible that this is wrong (and some upstream build tool
> just picked the installed version or something) but that's where we
> took it from.
I see.
> Then you can just as well remove it, since an unversioned
> libmodule-build-perl is provided by per-modules.
> (Which contains Module::Build 0.340201 in 5.10.1.)
The attached commit does remove the build-deps and also reduces the version
requirement in META.*. Otherwise, it would not build on wheezy, because newer
Modules::Build do a version check and die.
> I guess we could remove it from this package after checking that
> there are no differences. Could you file a bug report please so we
> don't forget it?
With the patch I can git-buildpackage this on squeeze, wheezy, sid, with and
without libmodule-build-perl installed. `debdiff` against a built of
origin/master shows nothing in any of the 6 packages I built, they're all the
same. Are there any objections against me pushing this commit?
Carsten
From c16288a89a2761f1f5ee24bb0ca8c7dd1491cb13 Mon Sep 17 00:00:00 2001
From: Carsten Wolff <carsten@wolffcarsten.de>
Date: Thu, 13 Jun 2013 11:59:26 +0200
Subject: [PATCH] fix Module::Build version requirement
---
debian/control | 3 +--
debian/patches/fix-module-build-requirement | 28 +++++++++++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 30 insertions(+), 2 deletions(-)
create mode 100644 debian/patches/fix-module-build-requirement
create mode 100644 debian/patches/series
diff --git a/debian/control b/debian/control
index ddc51ed..bacc60f 100644
--- a/debian/control
+++ b/debian/control
@@ -11,8 +11,7 @@ Uploaders: Krzysztof Krzyzaniak (eloy) <eloy@debian.org>,
Nicholas Bamber <nicholas@periapt.co.uk>,
Fabrizio Regalli <fabreg@fabreg.it>,
Xavier Guimard <x.guimard@free.fr>
-Build-Depends: debhelper (>= 8),
- libmodule-build-perl (>= 0.390000) | perl (>= 5.15.2)
+Build-Depends: debhelper (>= 8)
Build-Depends-Indep: libtest-inter-perl,
libtest-pod-coverage-perl,
libtest-pod-perl,
diff --git a/debian/patches/fix-module-build-requirement b/debian/patches/fix-module-build-requirement
new file mode 100644
index 0000000..9584a64
--- /dev/null
+++ b/debian/patches/fix-module-build-requirement
@@ -0,0 +1,28 @@
+Description: Reduces the unnecessarily high version dependency on Module::Build
+ To ease builds of this package on different distribution versions, we reduce
+ the unneccessarily high version dependency on Module::Build
+
+Author: Carsten Wolff <carsten@wolffcarsten.de>
+
+--- libdate-manip-perl-6.39.orig/META.json
++++ libdate-manip-perl-6.39/META.json
+@@ -21,7 +21,7 @@
+ },
+ "configure" : {
+ "requires" : {
+- "Module::Build" : "0.39"
++ "Module::Build" : "0.34"
+ }
+ },
+ "runtime" : {
+--- libdate-manip-perl-6.39.orig/META.yml
++++ libdate-manip-perl-6.39/META.yml
+@@ -5,7 +5,7 @@ author:
+ build_requires:
+ Test::Inter: 0
+ configure_requires:
+- Module::Build: 0.39
++ Module::Build: 0.34
+ dynamic_config: 1
+ generated_by: 'Module::Build version 0.3901, CPAN::Meta::Converter version 2.120921'
+ license: perl
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..afe77b0
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-module-build-requirement
--
1.7.10.4
Reply to: