On Tue, 26 Feb 2013 15:10:05 +0200, Damyan Ivanov wrote: > > For example: > > I have module version 0.05 and this code converts it to 0.5. > > Yes. 0.05 and 0.5 are exactly the same for dpkg: > > $ dpkg --compare-versions 0.5 eq 0.05 && echo equal > equal > > This is true despite the upstream version starting with a 'v' or not, > that's why the condition is removed. Ack. Still I have to admit that I'm not very happy about the version mangling (the removing leading 0s part). Although dpkg is fine with it, it feels weird to have versions that diverge from upstream (and change back with the next git-import-orig anyway) for no good reason. -- Unless there is a good reason, of course! > Perhaps the code should only convert this: > > v2.003004 → 2.3.4 > > but not this: > > 2.003.004 → 2.3.4 > 2.003004 → 2.3.4 I'd rather have them as v2.003004 → 2.003004 2.003.004 → 2.003.004 2.003004 → 2.003004 but ... > Although I guess the whole point of the implementation was to play > nice with a module whose version changed from 2.3.3 to v2.003004. ... yes, that might have been a reason, or some mismatch between the filename and the included $VERSION. Seems this mangling comes from http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/dh-make-perl.git;a=commitdiff;h=385451609f5af2ace92c3838133dd4ed2c605608 Interesting is the removed TODO item (originally from me in b2e0c52a44e802fad23d45b1cc63f9893ef8a130) which points to the original problem of a discrepancy between the tarball and the VERSION in META.*. Unfortunately we now mangle the version even if the tarball has the same version :) Maybe this has also changed over time; I seem to see mostly x.yyyyyy versions nowadays (in both places), that's why I noticed dh-make-perl's behaviour more often recently. What do others think about this version changing? Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Wet, Wet, Wet: Love Is All Around Me
Attachment:
signature.asc
Description: Digital signature