[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: dh-make-perl.git commit



Hi,

The proper place to discuss dh-make-perl is 
debian-perl@lists.debian.org (in CC).

-=| Michal Špaček, 25.02.2013 16:04:27 +0100 |=-
> About this commit:
> http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/dh-make-perl.git;a=commitdiff;h=6f8382c6da5ba28d54943c6fb0f9553dfa777143
> 
> I mean, that this patch isn't right.
> You remove if ($ver =~ m/^v/ms).

Yes, see below.

> For example:
> I have module version 0.05 and this code converts it to 0.5.

Yes. 0.05 and 0.5 are exactly the same for dpkg:

 $ dpkg --compare-versions 0.5 eq 0.05 && echo equal
 equal

This is true despite the upstream version starting with a 'v' or not, 
that's why the condition is removed.


Perhaps the code should only convert this:

 v2.003004 → 2.3.4

but not this:

 2.003.004 → 2.3.4
 2.003004 → 2.3.4

Although I guess the whole point of the implementation was to play 
nice with a module whose version changed from 2.3.3 to v2.003004.

Attachment: signature.asc
Description: Digital signature


Reply to: