[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please upload libparse-dia-sql-perl



On Tue, 25 May 2010 11:33:11 +0200, Gaudenz Steinlin wrote:

> I added libparse-dia-sql-perl to the SVN repository. This is a package
> that I wanted to sponsor and the sponsoree agreed to maintain it under
> the umbrella of the Debian Perl group. 

/me waves to Andreas

> The package is already tagged in SVN and ready for an upload.

I took a look at it, but IMO it's not completely ready for upload.
From my quick glance:

- missing debian/source/format (most new packages have "3.0 (quilt)")
- missing Vcs-* headers in d/control
- installing the README seems useless, we normally skip that kind of
  READMEs
- upstream copyright year missing in debian/control
- license: GPL doesn't make me happy (which one?) but that's an
  upstream question
- short description: should be a noun phrase, and no full stop at the
  end
- libtest-exception-perl seems unnecessary in Depends (comes from
  META.yml)
- IO::Uncompress::Gunzip needs "perl (>= 5.10) | libio-compress-perl
  | libio-compress-zlib-perl"
- setting AUTHOR_TEST and adding some build-deps might enable
  additional tests but that's of course debatable

I'm adding this notes to debian/changelog and set the distribution
back to UNRELEASED (to move it into the correct section in
http://pkg-perl.alioth.debian.org/cgi-bin/pet.cgi ).

Andreas, don't hesitate to ask here or on #debian-perl if you need
more details or help!


Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: U2: Don't Say Goodbye

Attachment: signature.asc
Description: Digital signature


Reply to: