[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#515209: uscan: discrepancy with documentation on mungling



More joy, I've just discovered that the second regex is completely
invalid, and I don't understand what was uscan doing:

 opts=uversionmangle="s/^\d\.\d$/$&00/;s/^\d\.\d\d0$/$&0"

If you look closely, the last slash is missing!

On Sat, Feb 14, 2009 at 17:53, Martín Ferrari <tincho@debian.org> wrote:
> Package: devscripts
> Version: 2.10.45
> Severity: minor
>
> Hi, today I spotted a watchfile being reported as invalid on PET, while
> uscan processed it fine. I think this behaviour is incompatible with
> what is documented (and PET watchfile processor is based mostly on the
> documentation), and I also think that the documented behaviour is saner.
>
> This is the offending line:
>
> opts=uversionmangle="s/^\d\.\d$/$&00/;s/^\d\.\d\d0$/$&0" \
> http://search.cpan.org/dist/Term-Size/ \
> ..*/Term-Size-v?(\d[\d_.]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)
>
> As you can see, the quotes were intended to be put before
> 'uversionmangle', and PET follows the documentation: the code is split
> by semicolons and then executed. So it tries and fails to execute this
> code:
>
> "s/^\d\.\d$/$&00/;
>
> The log shows it clearly:
>
> Feb 14 19:43:32 fetchdata[17379]: Mangle option:
> "s/^\d\.\d$/$&00/;s/^\d\.\d\d0$/$&0"
> Feb 14 19:43:32 fetchdata[17379]: Executing '$mangled[-1] =~
> "s/^\d\.\d$/$&00/'
> Feb 14 19:43:32 fetchdata[17379]: Invalid watchfile: Can't find string
> terminator '"' anywhere before EOF at (eval 117) line 1.
>
> At the same time, uscan removes the quotes before the code, which I
> understand is not documented behaviour.
>
> -- Package-specific info:
>
> --- /etc/devscripts.conf ---
>
> --- ~/.devscripts ---
> DEBSIGN_KEYID=575D0A76
> DEBUILD_DPKG_BUILDPACKAGE_OPTS="-ICVS -I.svn"
> DEBUILD_LINTIAN=yes
> DEBUILD_LINDA=no
> USCAN_VERBOSE=yes
> DEBCHANGE_RELEASE_HEURISTIC=changelog
>
> -- System Information:
> Debian Release: 5.0
>  APT prefers unstable
>  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
> Architecture: i386 (i686)
>
> Kernel: Linux 2.6.26-1-686-bigmem (SMP w/2 CPU cores)
> Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
>
> Versions of packages devscripts depends on:
> ii  dpkg-dev                      1.14.24    Debian package development tools
> ii  libc6                         2.7-18     GNU C Library: Shared libraries
> ii  perl                          5.10.0-19  Larry Wall's Practical Extraction
>
> Versions of packages devscripts recommends:
> ii  at                 3.1.10.2              Delayed job execution and batch pr
> ii  bsd-mailx [mailx]  8.1.2-0.20081101cvs-2 A simple mail user agent
> ii  cvs                1:1.12.13-12          Concurrent Versions System
> ii  dctrl-tools        2.13.1                Command-line tools to process Debi
> ii  debian-keyring     2009.01.18            GnuPG (and obsolete PGP) keys of D
> ii  debian-maintainers 1.52                  GPG keys of Debian maintainers
> ii  dput               0.9.2.37              Debian package upload tool
> ii  epiphany-gecko [ww 2.22.3-9              Intuitive GNOME web browser - Geck
> ii  equivs             2.0.7-0.1             Circumvent Debian package dependen
> ii  fakeroot           1.12.1                Gives a fake root environment
> ii  git-core           1:1.5.6.5-2           fast, scalable, distributed revisi
> ii  gnupg              1.4.9-3               GNU privacy guard - a free PGP rep
> ii  iceweasel [www-bro 3.0.5-1               lightweight web browser based on M
> ii  libauthen-sasl-per 2.12-1                Authen::SASL - SASL Authentication
> ii  libcrypt-ssleay-pe 0.57-1+b1             Support for https protocol in LWP
> ii  libparse-debcontro 2.005-2               Easy OO parsing of Debian control-
> ii  libsoap-lite-perl  0.710.08-2            Client and server side SOAP implem
> ii  libterm-size-perl  0.2-4+b1              Perl extension for retrieving term
> ii  libtimedate-perl   1.1600-9              Time and date functions for Perl
> ii  liburi-perl        1.37+dfsg-1           Manipulates and accesses URI strin
> ii  libwww-perl        5.820-1               WWW client/server library for Perl
> ii  libyaml-syck-perl  1.05-1                Fast, lightweight YAML loader and
> ii  lintian            2.2.0                 Debian package checker
> ii  lsb-release        3.2-20                Linux Standard Base version report
> ii  lynx-cur [www-brow 2.8.7dev12-2          Text-mode WWW Browser with NLS sup
> ii  mailx              1:20081101-2          Transitional package for mailx ren
> ii  man-db             2.5.2-4               on-line manual pager
> ii  openssh-client [ss 1:5.1p1-5             secure shell client, an rlogin/rsh
> ii  patch              2.5.9-5               Apply a diff file to an original
> ii  patchutils         0.3.1-1               Utilities to work with patches
> ii  strace             4.5.17+cvs080723-2    A system call tracer
> ii  subversion         1.5.1dfsg1-2          Advanced version control system
> ii  unzip              5.52-12               De-archiver for .zip files
> ii  wdiff              0.5-18                Compares two files word by word
> ii  wget               1.11.4-2              retrieves files from the web
>
> Versions of packages devscripts suggests:
> ii  build-essential               11.4       Informational list of build-essent
> pn  cvs-buildpackage              <none>     (no description available)
> pn  devscripts-el                 <none>     (no description available)
> pn  gnuplot                       <none>     (no description available)
> pn  libfile-desktopentry-perl     <none>     (no description available)
> pn  libnet-smtp-ssl-perl          <none>     (no description available)
> pn  mutt                          <none>     (no description available)
> ii  svn-buildpackage              0.6.23     helper programs to maintain Debian
>
> -- no debconf information
>
>
>



-- 
Martín Ferrari


Reply to: