Hi Charles, hi all
Thanks for your reply on that and sorry for the delay (was on
vacation).
On Mon, Oct 12, 2009 at 06:45:31PM +0900, Charles Plessy wrote:
> Le Sun, Oct 04, 2009 at 07:07:49PM +0200, Salvatore Bonaccorso a écrit :
> >
> > [...]
> >
> > would it be possible here, that since License-Alias is not anymore in
> > DEP5, to include to not report copyright-refers-to-symlink-license
> > also if "License: Artistic or GPL-1+" is present?
> >
> > Would it be possible to have somethin like (not tested yet!)
> > ---(patch)--------------------------------------------------------------
> > --- lintian-2.2.17.orig/checks/copyright-file 2009-10-04 19:01:38.000000000 +0200
> > +++ lintian-2.2.17/checks/copyright-file 2009-10-04 19:04:43.000000000 +0200
> > @@ -161,7 +161,8 @@
> > # our false positives for GPL references that don't include a specific version
> > # number, but it will get the obvious ones.
> > if (m,(usr/share/common-licenses/(L?GPL|GFDL))([^-]),i && !m,as Perl itself,i
> > - && !m,License-Alias:\s+Perl,) {
> > + && !m,License-Alias:\s+Perl,
> > + && !m,License:\s+Artistic\s+or\s+GPL-1\+,) {
> > my ($ref, $license, $separator) = ($1, $2, $3);
> > if ($separator =~ /[\d\w]/) {
> > tag 'copyright-refers-to-nonexistent-license-file', "$ref$separator";
> > ------------------------------------------------------------------------
>
> Dear all,
>
> the License-Alias field was indeed removed from the DEP 5 proposal, which now
> speficies directly that the Perl license keyword means ‘GPL-1+ or Artistic’.
> Hence, I would recommend to simply use ‘License: Perl’. Therefore, the above
> regular expression could be: m,License(?:-Alias)?\s*:\s+Perl,
> (not tested).
Ok, I agree with that. My reasoning was to have also the "License:
Artistic or GPL-1+" matched too, since this is still 'alowed' even
there is the keyword "License: Perl". But my above proposal does not
cover the case "License: Perl", you are right.
Charles, would you agree to have the above for "License-Alias: Perl",
"License: Perl" and "License: Artistic or GPL-1+"?
Bests
Salvatore
Attachment:
signature.asc
Description: Digital signature