On Sat, 05 Jan 2008 22:17:16 -0600, Rene Mayorga wrote: > > Question to the team: > > Are there any objections to running `packagecheck' [0] against trunk > > to prepend all rmdirs with "[ ! -d $dir ] ||" (the script also > > catches the "find -type -d -empty ..." cases)? > Since this get discussed I already start to use "[ ! -d $dir ] ||" > approach. You're not the only one :) > btw, I tested packagecheck, nice work :), Thanks for testing and the feedback! > it looks nice, but its matching only "rmdir.*ignore-fail-on-non-empty", > so after run packagecheck I toked a quick look/grep and there are some > packages missed because they use "rm -r" instead "rmdir" Right, I've been thinking about that, too. *testing some patterns for grep* egrep "rm -r.*usr/(lib|share)(/perl5)?$" looks quite good; catches 36 packages with no false positives. Ok, I've added this to the current search pattern. Thanks for the hint! Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: The Who: Pinball Wizard
Attachment:
signature.asc
Description: Digital signature