[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New Perl package diff files

Le Sat, Jun 19, 1999 at 06:31:04AM -0700, Darren/Torin/Who Ever... écrivait:
> Well, I've not had a chance to test the packages yet, so, I'm putting
> the diffs on my ftp/http site.  I know that they at least build; look
> decent; and lintian only complains -some-.  I'll be doing more on them
> today/tonight.  Next thing is testing.  Then I'll go back to fixing them 
> up some more.

I've found one copy/paste problem. It's in perl-base.postinst from
both perl-5.004 and perl-5.005 :

there's 'perl-=version' instead of 'perl-=version='

Also when you merged my work, you lost the install of POSIX stuff into
perl-base. I don't know if it was intentional ... you may not notice 
it because it was only a two-line change in perl-=version=-base.files.MK,
at the end there was that :

The first line is a complete directory and the second is 2 files : POSIX.pm
and POSIX.pod. You may want to install POSIX.pod somewhere else than
in perl-base. I did that because it does correct of the bug that I
submitted in order to enable the internationalization of the base system.

I also noticed a changes that I made to the lib/anydbm.t in order to
test something that I forgot to remove, you can reverse-apply this patch (in
perl-5.004 and perl-5.005), however one of the test may fail (the 12th test
about the empty key) :
--- perl-5.005-5.005.03.orig/t/lib/anydbm.t
+++ perl-5.005-5.005.03/t/lib/anydbm.t
@@ -7,6 +7,8 @@
     @INC = '../lib';
 require AnyDBM_File;
+BEGIN { @AnyDBM_File::ISA = qw(GDBM_File NDBM_File) }
 #If Fcntl is not available, try 0x202 or 0x102 for O_RDWR|O_CREAT
 use Fcntl;
After this short review of the diff, i'll build the packages and do some
upgrade tests.

Hertzog Raphaël >> 0C4CABF1 >> http://prope.insa-lyon.fr/~rhertzog/

Reply to: