[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[nolden@kde.org: oooqs-1.0rc3 patch]



Hi,

As debian-openoffice@ is the Maintainer: this really belongs here ;)

----- Forwarded message from Ralf Nolden <nolden@kde.org> -----

From: Ralf Nolden <nolden@kde.org>
Organization: The KDesktop Environment
To: Christian Nitschkowski <SegFault_II@web.de>
Subject: oooqs-1.0rc3 patch
Date: Fri, 17 Oct 2003 17:10:52 +0200
User-Agent: KMail/1.5.4
Cc: Rene Engelhard <rene@debian.org>

Content-Description: signed data
Content-Description: body text
Hi guys,

while using the debian package for oooqs I found that the preferences dialog 
layout is erm, a bit messy :-}  I would have preferred that it was made with 
designer, though it is hardcoded and therefore a bit more difficult to patch. 
Attached is a patch that fixes the layouts of the three groupboxes in the 
general preferences section of the configuration dialog. Without the patch 
you're using the unmanaged groupbox which doesn't have automatic layouting, 
so I used another constructor that makes all the other function calls 
obsolete.

Please apply the patch to the debian package and use it in the original source 
distribution.

Thanks,

Ralf
-- 
We're not a company, we just produce better code at less costs.
--------------------------------------------------------------------
Ralf Nolden
nolden@kde.org

The K Desktop Environment       The KDevelop Project
http://www.kde.org              http://www.kdevelop.org

--- oooqs-1.0rc3.old/oooqs/prefsdialog.cpp	Thu Oct  3 16:06:44 2002
+++ oooqs-1.0rc3/oooqs/prefsdialog.cpp	Fri Oct 17 17:05:19 2003
@@ -60,53 +60,41 @@
 	prefDialogLayout->addWidget( suiteBox );
 	prefDialogLayout->addItem(spacer_50);
 
-	QGroupBox* GroupBox1 = new QGroupBox( generalContainer, "GroupBox1" );
-	GroupBox1->setTitle( i18n( "Select your %1 installpath" ).arg(((OooQs*)parent)->suite) );
-	GroupBox1->setColumnLayout(0, Qt::Vertical );
+	QGroupBox* GroupBox1 = new QGroupBox( 1, Qt::Vertical, 
+		i18n( "Select your %1 installpath" ).arg(((OooQs*)parent)->suite), generalContainer, "GroupBox1" );
 	GroupBox1->layout()->setSpacing( 6 );
 	GroupBox1->layout()->setMargin( 11 );
-	QGridLayout* GroupBox1Layout = new QGridLayout( GroupBox1->layout() );
-	GroupBox1Layout->setAlignment( Qt::AlignTop );
 
 	binary = new KURLRequester( GroupBox1, "binary" );
 	binary->fileDialog()->setOperationMode(KFileDialog::Opening);
 	binary->setMode(2+8);
 
-	GroupBox1Layout->addWidget( binary, 0, 0 );
 	prefDialogLayout->addWidget( GroupBox1 );
 	QSpacerItem* spacer_2 = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding );
 	prefDialogLayout->addItem( spacer_2 );
 
-	QGroupBox* GroupBox3 = new QGroupBox( generalContainer, "GroupBox3" );
-	GroupBox3->setTitle( i18n( "Select your documents-directory" ) );
-	GroupBox3->setColumnLayout(0, Qt::Vertical );
+	QGroupBox* GroupBox3 = new QGroupBox( 1, Qt::Vertical,
+		i18n( "Select your documents-directory" ), generalContainer, "GroupBox3" );
 	GroupBox3->layout()->setSpacing( 6 );
 	GroupBox3->layout()->setMargin( 11 );
-	QGridLayout* GroupBox3Layout = new QGridLayout( GroupBox3->layout() );
-	GroupBox3Layout->setAlignment( Qt::AlignTop );
 
 	documents = new KURLRequester( GroupBox3, "documents" );
 	documents->fileDialog()->setOperationMode(KFileDialog::Opening);
 	documents->setMode(2+8);
 
-	GroupBox3Layout->addWidget( documents, 0, 0 );
 	prefDialogLayout->addWidget( GroupBox3 );
 	QSpacerItem* spacer_3 = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding );
 	prefDialogLayout->addItem( spacer_3 );
 
-	QGroupBox* GroupBox4 = new QGroupBox( generalContainer, "GroupBox4" );
-	GroupBox4->setTitle( i18n( "Select your templates-directory" ) );
-	GroupBox4->setColumnLayout(0, Qt::Vertical );
+	QGroupBox* GroupBox4 = new QGroupBox( 1, Qt::Vertical, 
+		i18n( "Select your templates-directory" ), generalContainer, "GroupBox4" );
 	GroupBox4->layout()->setSpacing( 6 );
 	GroupBox4->layout()->setMargin( 11 );
-	QGridLayout* GroupBox4Layout = new QGridLayout( GroupBox4->layout() );
-	GroupBox4Layout->setAlignment( Qt::AlignTop );
 
 	templates = new KURLRequester( GroupBox4, "templates" );
 	templates->fileDialog()->setOperationMode(KFileDialog::Opening);
 	templates->setMode(2+8);
 
-	GroupBox4Layout->addWidget( templates, 0, 0 );
 	prefDialogLayout->addWidget( GroupBox4 );
 	QSpacerItem* spacer_3_2 = new QSpacerItem( 20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding );
 	prefDialogLayout->addItem( spacer_3_2 );




----- End forwarded message -----

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73
      

Attachment: signature.asc
Description: Digital signature


Reply to: