Hi Ralf, On Thu, Jul 28, 2016 at 09:01:56PM +0200, Ralf Treinen wrote: > 1) Concerning the patch 0001-Build-docs-*: > > + $(H) cd ../mathcomp; $(COQBIN)/coqdep -R . mathcomp $(SRC) | \ > + grep -v 'vio:' > ../htmldoc/depends > > this replaces a line where the result was written to ../htmldoc/depend > (note the missing final "s"). Is this on purpose ? Great catch! No, it isn't on purpose, and it made the generated dep. graph wrong. > Also, it seems to me that some of the modifications in the patch are > purely cosmetic (like formatting, avoiding an unnecessary cat). I don't > think that it is a good idea to do cosmetic changes in a patch, as each > modification makes it harder to carry the patch forward to new releases. > If you have minor modifications it would be better to transmit them > directly to upstream. Unfortunately, those modifications aren't so minor: I had to heavily patch the Makefile to make mathcomp buildable outside a clone of the upstream git repo. The cosmetic changes are only a side-effect of those (larger) changes. I would be happy to send thos echanges back upstream, but I would rather get the package working with the current release first. > 2) Another remark concerns the organisation of debian/rules. You now have > two Architecture=any packages, these will be build by the autobuilders. > These packages alone should be quick to compile. [...] > Do you think you can do this ? This would also allow you to move > some of the Build-Dependencies into Build-Depends-Indep. I'm not sure the coqdoc documentation can be built without building the rest, but I can try at some point. > 3.) % lintian *.changes > E: mathcomp source: source-is-missing htmldoc/js/cytoscape.js line length > is 849 characters (>512) > E: mathcomp source: source-is-missing htmldoc/js/dagre.js line length is > 803 characters (>512) > W: mathcomp source: debhelper-but-no-misc-depends mathcomp-doc > > The last one is easy to fix. Can anything be done about the first two? I fixed the last one. The first two are JS things that don't seem packaged yet in Debian. This is dirty, but since I know nothing about those two things I'm not sure repackaging mathcomp (to remove the code copies) and packaging the JS things separately is a good idea (or something I could maintain). > Thanks for all your work ! Cheers -Ralf. Likewise, thanks a lot for the review :) Best, nicoo
Attachment:
signature.asc
Description: PGP signature