Bug#789403: FTBFS with OCaml 4.02.2: Some fatal warnings were triggered

To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#789403: FTBFS with OCaml 4.02.2: Some fatal warnings were triggered
From: Stéphane Glondu <glondu@debian.org>
Date: Sat, 20 Jun 2015 17:02:20 +0200
Message-id: <[🔎] 20150620150220.29781.76862.reportbug@korell.up7.fr>
Reply-to: Stéphane Glondu <glondu@debian.org>, 789403@bugs.debian.org

Source: llvm-toolchain-3.4
Version: 3.4.2-14
Severity: important
Tags: patch

Dear Maintainer,

Your package FTBFS with OCaml 4.02.2:
> [...]
> Command Output (stderr):
> --
> File "/tmp/pbuilder/llvm-toolchain-3.4-3.4.2/build-llvm/test/Bindings/Ocaml/Output/bitwriter.ml.tmp.builddir/bitwriter.ml", line 20, characters 12-25:
> Warning 3: deprecated: String.create
> Use Bytes.create instead.
> File "/tmp/pbuilder/llvm-toolchain-3.4-3.4.2/build-llvm/test/Bindings/Ocaml/Output/bitwriter.ml.tmp.builddir/bitwriter.ml", line 1:
> Error: Some fatal warnings were triggered (1 occurrences)
> [...]

I suggest to not use the -warn-error option. With the attached patch,
the package builds. It should as well build with the version of OCaml
currently in unstable, so I suggest you to upload it as soon as
possible, and not wait for the transition to start.

Cheers,

-- 
Stéphane

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru llvm-toolchain-3.4-3.4.2/debian/changelog llvm-toolchain-3.4-3.4.2/debian/changelog
--- llvm-toolchain-3.4-3.4.2/debian/changelog	2015-05-07 09:22:00.000000000 +0200
+++ llvm-toolchain-3.4-3.4.2/debian/changelog	2015-06-20 08:07:10.000000000 +0200
@@ -1,3 +1,10 @@
+llvm-toolchain-3.4 (1:3.4.2-14.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix compilation with OCaml 4.02
+
+ -- Stéphane Glondu <glondu@debian.org>  Sat, 20 Jun 2015 06:07:10 +0000
+
 llvm-toolchain-3.4 (1:3.4.2-14) unstable; urgency=medium
 
   * d/patches/isl-0.13-compat.diff, ensure compatibility with libisl13
diff -Nru llvm-toolchain-3.4-3.4.2/debian/patches/-fix-ftbfs-ocaml-4.02 llvm-toolchain-3.4-3.4.2/debian/patches/-fix-ftbfs-ocaml-4.02
--- llvm-toolchain-3.4-3.4.2/debian/patches/-fix-ftbfs-ocaml-4.02	1970-01-01 01:00:00.000000000 +0100
+++ llvm-toolchain-3.4-3.4.2/debian/patches/-fix-ftbfs-ocaml-4.02	2015-06-20 08:15:12.000000000 +0200
@@ -0,0 +1,147 @@
+Description: Fix FTBFS with OCaml 4.02
+ New warnings were introduced in OCaml 4.02; do not use -warn-error.
+Author: Stéphane Glondu <glondu@debian.org>
+
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/analysis.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/analysis.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_analysis.cmxa %t.builddir/analysis.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_analysis.cmxa %t.builddir/analysis.ml -o %t
+  * RUN: %t
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/bitreader.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/bitreader.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_bitreader.cmxa llvm_bitwriter.cmxa %t.builddir/bitreader.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_bitreader.cmxa llvm_bitwriter.cmxa %t.builddir/bitreader.ml -o %t
+  * RUN: %t %t.bc
+  * RUN: llvm-dis < %t.bc
+  * XFAIL: vg_leak
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/bitwriter.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/bitwriter.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A unix.cmxa llvm.cmxa llvm_bitwriter.cmxa %t.builddir/bitwriter.ml -o %t
++ * RUN: %ocamlopt  unix.cmxa llvm.cmxa llvm_bitwriter.cmxa %t.builddir/bitwriter.ml -o %t
+  * RUN: %t %t.bc
+  * RUN: llvm-dis < %t.bc
+  * XFAIL: vg_leak
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/executionengine.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/executionengine.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_target.cmxa llvm_executionengine.cmxa %t.builddir/executionengine.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_target.cmxa llvm_executionengine.cmxa %t.builddir/executionengine.ml -o %t
+  * RUN: %t
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/ext_exc.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/ext_exc.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_bitreader.cmxa llvm_executionengine.cmxa %t.builddir/ext_exc.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_bitreader.cmxa llvm_executionengine.cmxa %t.builddir/ext_exc.ml -o %t
+  * RUN: %t </dev/null
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/ipo_opts.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/ipo_opts.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_ipo.cmxa llvm_target.cmxa %t.builddir/ipo_opts.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_ipo.cmxa llvm_target.cmxa %t.builddir/ipo_opts.ml -o %t
+  * RUN: %t %t.bc
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/irreader.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/irreader.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -g -warn-error A llvm.cmxa llvm_irreader.cmxa %t.builddir/irreader.ml -o %t
++ * RUN: %ocamlopt -g  llvm.cmxa llvm_irreader.cmxa %t.builddir/irreader.ml -o %t
+  * RUN: %t
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/linker.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/linker.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_linker.cmxa %t.builddir/linker.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_linker.cmxa %t.builddir/linker.ml -o %t
+  * RUN: %t
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/passmgr_builder.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/passmgr_builder.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_passmgr_builder.cmxa %t.builddir/passmgr_builder.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_passmgr_builder.cmxa %t.builddir/passmgr_builder.ml -o %t
+  * RUN: %t %t.bc
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/scalar_opts.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/scalar_opts.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_scalar_opts.cmxa llvm_target.cmxa %t.builddir/scalar_opts.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_scalar_opts.cmxa llvm_target.cmxa %t.builddir/scalar_opts.ml -o %t
+  * RUN: %t %t.bc
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/target.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/target.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -g -warn-error A llvm.cmxa llvm_target.cmxa llvm_executionengine.cmxa %t.builddir/target.ml -o %t
++ * RUN: %ocamlopt -g  llvm.cmxa llvm_target.cmxa llvm_executionengine.cmxa %t.builddir/target.ml -o %t
+  * RUN: %t %t.bc
+  * REQUIRES: native, object-emission
+  * XFAIL: vg_leak
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/vectorize_opts.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/vectorize_opts.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_vectorize.cmxa llvm_target.cmxa %t.builddir/vectorize_opts.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_vectorize.cmxa llvm_target.cmxa %t.builddir/vectorize_opts.ml -o %t
+  * RUN: %t %t.bc
+  * XFAIL: vg_leak
+  *)
+--- llvm-toolchain-3.4-3.4.2.orig/test/Bindings/Ocaml/vmcore.ml
++++ llvm-toolchain-3.4-3.4.2/test/Bindings/Ocaml/vmcore.ml
+@@ -1,7 +1,7 @@
+ (* RUN: rm -rf %t.builddir
+  * RUN: mkdir -p %t.builddir
+  * RUN: cp %s %t.builddir
+- * RUN: %ocamlopt -warn-error A llvm.cmxa llvm_analysis.cmxa llvm_bitwriter.cmxa %t.builddir/vmcore.ml -o %t
++ * RUN: %ocamlopt  llvm.cmxa llvm_analysis.cmxa llvm_bitwriter.cmxa %t.builddir/vmcore.ml -o %t
+  * RUN: %t %t.bc
+  * RUN: llvm-dis < %t.bc > %t.ll
+  * RUN: FileCheck %s < %t.ll
diff -Nru llvm-toolchain-3.4-3.4.2/debian/patches/series llvm-toolchain-3.4-3.4.2/debian/patches/series
--- llvm-toolchain-3.4-3.4.2/debian/patches/series	2015-05-07 09:21:27.000000000 +0200
+++ llvm-toolchain-3.4-3.4.2/debian/patches/series	2015-06-20 08:11:13.000000000 +0200
@@ -46,3 +46,4 @@
 remove-dbtree.diff
 kfreebsd-path.diff
 isl-0.13-compat.diff
+-fix-ftbfs-ocaml-4.02

Reply to:

Prev by Date: Bug#789402: FTBFS with OCaml 4.02.2: Some fatal warnings were triggered
Next by Date: Processed: block 789133 with 789354
Previous by thread: Bug#789402: FTBFS with OCaml 4.02.2: Some fatal warnings were triggered
Next by thread: Processed: block 789133 with 789354
Index(es):
- Date
- Thread