Re: Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
On Thu, May 23, 2013 at 6:38 PM, Stéphane Glondu <glondu@debian.org> wrote:
> Le 23/05/2013 05:45, Prach Pongpanich a écrit :
>> Packaging a new upstream 2.2.0:
>
> Sorry for taking so long, but I wanted to look at the whole thread
> first... which I haven't done so far. Anyway, since you've been waiting
> for some time now, I've just directly looked at your package without
> looking at previous comments.
>
>> dget -x http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.2.0-1.dsc
>>
>> http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git
>
> Please do not override Lintian tags about hardening.
>
> Native plugins should be installed only when natdynlink is available,
> please consider s/OPT/DYN/ in librss-ocaml.install.in.
>
> Please add ${shlibs:Depends} to -dev package as well.
>
> The relationship with Cameleon described in the description suggests a
> versioned Breaks/Replaces relationship instead of a Conflicts.
>
> A period is missing at the end of the -dev description.
>
> rss_date.* files have been removed in version 2.1.0. Please update
> debian/copyright accordingly.
>
> You say "LGPL-3+" in debian/copyright whereas it is written "LGPL-3" (no
> "or later" clause) everywhere else. Please fix.
>
Thanks for your review and suggestion, I have done all of the above.
http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git
Regrads,
Prach
Reply to: